Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34424

AOS rotation: rotate M1 surface grid

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      The finding of DM-34065, which confirms https://confluence.lsstcorp.org/display/LTS/Closed-Loop+Simulation+with+Non-Zero+Camera+Rotation+Angle was that rotTelPos does not change the angle between the camera and the M1M3 assembly. As https://sitcomtn-003.lsst.io/#camera-rotator explains, there are various ways to address nonzero camera rotator angle, and one is implemented in ts_ofc  (https://github.com/lsst-ts/ts_ofc/blob/develop/python/lsst/ts/ofc/camrot.py used in https://github.com/lsst-ts/ts_ofc/blob/f33ffaf1f84dcdd7e7d526118c647cffcc7bf4ef/python/lsst/ts/ofc/ofc.py#L232 ).

       

      The goal of this ticket is to rotate the calculated grid surface for M1, such as `randSurfInM` in https://github.com/lsst-ts/ts_phosim/blob/2d3ab7a18d5ba89c719a232a4beba19f8443724e/python/lsst/ts/phosim/telescope/M1M3Sim.py#L631 . It would be physically correct to rotate M1, M2, and M3 to "fake" the camera rotation. However, the main perturbation terms come from M1, and dominates those of M2,M3. So to test the principle, we try first only rotate M1.  Then inspect the generated donut images and  OPDs, and compare to the un-rotated images. Check whether retrieved Zernikes are rotated or not. 

        Attachments

          Issue Links

            Activity

            ksuberlak Krzysztof Suberlak created issue -
            ksuberlak Krzysztof Suberlak made changes -
            Field Original Value New Value
            Link This issue is child task of DM-33116 [ DM-33116 ]
            ksuberlak Krzysztof Suberlak made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            ksuberlak Krzysztof Suberlak made changes -
            Watchers Krzysztof Suberlak, Te-Wei Tsai [ Krzysztof Suberlak, Te-Wei Tsai ] Andrew Connolly, Krzysztof Suberlak, Te-Wei Tsai [ Andrew Connolly, Krzysztof Suberlak, Te-Wei Tsai ]
            Description The finding of DM-34065, which confirms [https://confluence.lsstcorp.org/display/LTS/Closed-Loop+Simulation+with+Non-Zero+Camera+Rotation+Angle] was that rotTelPos does not change the angle between the camera and the M1M3 assembly. As [https://sitcomtn-003.lsst.io/#camera-rotator] explains, there are various ways to address nonzero camera rotator angle, and one is implemented in ts_ofc  ([https://github.com/lsst-ts/ts_ofc/blob/develop/python/lsst/ts/ofc/camrot.py] used in [https://github.com/lsst-ts/ts_ofc/blob/f33ffaf1f84dcdd7e7d526118c647cffcc7bf4ef/python/lsst/ts/ofc/ofc.py#L232] ).

             

            The goal of this ticket is to rotate the calculated grid surface, such as `randSurfInM` in [https://github.com/lsst-ts/ts_phosim/blob/2d3ab7a18d5ba89c719a232a4beba19f8443724e/python/lsst/ts/phosim/telescope/M1M3Sim.py#L631] . Then inspect the generated donut images and  OPDs, and compare to the un-rotated images. Check whether retrieved Zernikes are rotated or not. 
            The finding of DM-34065, which confirms [https://confluence.lsstcorp.org/display/LTS/Closed-Loop+Simulation+with+Non-Zero+Camera+Rotation+Angle] was that rotTelPos does not change the angle between the camera and the M1M3 assembly. As [https://sitcomtn-003.lsst.io/#camera-rotator] explains, there are various ways to address nonzero camera rotator angle, and one is implemented in ts_ofc  ([https://github.com/lsst-ts/ts_ofc/blob/develop/python/lsst/ts/ofc/camrot.py] used in [https://github.com/lsst-ts/ts_ofc/blob/f33ffaf1f84dcdd7e7d526118c647cffcc7bf4ef/python/lsst/ts/ofc/ofc.py#L232] ).

             

            The goal of this ticket is to rotate the calculated grid surface for M1, such as `randSurfInM` in [https://github.com/lsst-ts/ts_phosim/blob/2d3ab7a18d5ba89c719a232a4beba19f8443724e/python/lsst/ts/phosim/telescope/M1M3Sim.py#L631] . It would be physically correct to rotate M1, M2, and M3 to "fake" the camera rotation. However, the main perturbation terms come from M1, and dominates those of M2,M3. So to test the principle, we try first only rotate M1.  Then inspect the generated donut images and  OPDs, and compare to the un-rotated images. Check whether retrieved Zernikes are rotated or not. 
            ksuberlak Krzysztof Suberlak made changes -
            Attachment image-2022-04-29-14-04-39-929.png [ 59246 ]
            ksuberlak Krzysztof Suberlak made changes -
            Attachment image-2022-04-29-14-05-14-374.png [ 59247 ]
            ksuberlak Krzysztof Suberlak made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            jmeyers314 Joshua Meyers made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            ksuberlak Krzysztof Suberlak made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            aclements Andy Clements made changes -
            Epic Link DM-30790 [ 530188 ] DM-29391 [ 463462 ]

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Joshua Meyers
              Watchers:
              Andrew Connolly, Joshua Meyers, Krzysztof Suberlak, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Due:
                Created:
                Updated:
                Resolved:
                Start date:

                  Jenkins

                  No builds found.