Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34452

Deprecate calibrate.doInsertFakes and remove gen2-only tests.

    XMLWordPrintable

    Details

      Description

      As part of DM-34339, we can remove the even-more-ancient synpipe port that includes calibrate.doInsertFakes and is not used anywhere. In particular, test_fakeProcessing.py is a test that is gen2-only and uses obs_test and can be removed.

      This ticket is leaving multiBand.insertFakes as is.

        Attachments

          Issue Links

          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34339 Deprecate old fake-source injection interfaces

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-841 Deprecate and remove the old fake-source injection interfaces

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34496 Remove already-deprecated fake-source insertion interfaces

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good, but are you sure this isn't actually all of DM-34339? If you do know of any specific part of that ticket that you aren't doing here, could you make a note of it there?

            Show
            jbosch Jim Bosch added a comment - Looks good, but are you sure this isn't actually all of DM-34339 ? If you do know of any specific part of that ticket that you aren't doing here, could you make a note of it there?
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            I removed more from multiBand from the ancient code, but left the hasFakes which is in the now-being-deprecated code (thanks Sophie Reed for the review of the next part.)

            Show
            erykoff Eli Rykoff added a comment - I removed more from multiBand from the ancient code, but left the hasFakes which is in the now-being-deprecated code (thanks Sophie Reed for the review of the next part.)

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Jim Bosch
              Watchers:
              Eli Rykoff, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.