Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3447

Improve packaging of shared libraries in scons

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      As discovered through DM-3161, our swig-generated libraries are messy. Specifically, we are dumping everything we might need into the czarLib library. That includes mysql and mysql-client related things. CssLib needs mysql functions too. Given that czar imports both these libraries, we ended up with duplicate symbols. That is being patched in DM-3161, but it needs a further look / cleanup. We need to break things into smaller libraries. Difficulty: understanding dependencies and avoiding circular dependencies.

        Attachments

          Issue Links

            Activity

            Hide
            jbecla Jacek Becla added a comment -

            should we switch to "in review" then?

            Show
            jbecla Jacek Becla added a comment - should we switch to "in review" then?
            Hide
            salnikov Andy Salnikov added a comment -

            Thanks Jacek, I forgot about that, please send your comments now, everyone

            Show
            salnikov Andy Salnikov added a comment - Thanks Jacek, I forgot about that, please send your comments now, everyone
            Hide
            fritzm Fritz Mueller added a comment -

            Yay! Looks good to me, and a big improvement over what we had for sure. Serge Monkewitz, please move to "review complete" when done.

            Show
            fritzm Fritz Mueller added a comment - Yay! Looks good to me, and a big improvement over what we had for sure. Serge Monkewitz , please move to "review complete" when done.
            Hide
            smonkewitz Serge Monkewitz added a comment -

            I did not have time for a detailed review, only a cursory glance. You've managed to get rid of a bunch of repetitive boiler-plate, and I also really appreciate that you took the time to add good documentation for standardModule. Looks good!

            Show
            smonkewitz Serge Monkewitz added a comment - I did not have time for a detailed review, only a cursory glance. You've managed to get rid of a bunch of repetitive boiler-plate, and I also really appreciate that you took the time to add good documentation for standardModule . Looks good!
            Hide
            salnikov Andy Salnikov added a comment -

            Thanks for reviews! Merged and pushed to master.

            Show
            salnikov Andy Salnikov added a comment - Thanks for reviews! Merged and pushed to master.

              People

              • Assignee:
                salnikov Andy Salnikov
                Reporter:
                fritzm Fritz Mueller
                Reviewers:
                Fritz Mueller, Serge Monkewitz
                Watchers:
                Andy Salnikov, Fritz Mueller, Jacek Becla, Joshua Hoblitt, Serge Monkewitz, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel