Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34496

Remove already-deprecated fake-source insertion interfaces

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • pipe_tasks
    • None

    Description

      This includes the doInsertFakes and insertFakes config options in CalibrateTask and DetectCoaddSources, as well as BaseFakeSourcesTask. Deprecation occurred on DM-34452.

      Attachments

        Issue Links

          Activity

            trysmccann Trys McCann added a comment -

            Understood. Since I am removing fakes.py (containing BaseFakeSourcesTask) , I assume I should remove doc/lsst.pipe.tasks/tasks/lsst.pipe.tasks.fakes.BaseFakeSourcesTask.rst

            trysmccann Trys McCann added a comment - Understood. Since I am removing fakes.py (containing BaseFakeSourcesTask) , I assume I should remove doc/lsst.pipe.tasks/tasks/lsst.pipe.tasks.fakes.BaseFakeSourcesTask.rst
            lskelvin Lee Kelvin added a comment -

            Yes, I think that sounds right. We'll need to scour through the stack to make sure that all references to these configs/classes are removed on this ticket.

            lskelvin Lee Kelvin added a comment - Yes, I think that sounds right. We'll need to scour through the stack to make sure that all references to these configs/classes are removed on this ticket.
            trysmccann Trys McCann added a comment - - edited

            Jenkins run succeeded with the changes discussed above. Code is ready for review! Yusra and I pair coded other stack removals (of which there happened to be none).

            trysmccann Trys McCann added a comment - - edited Jenkins run succeeded with the changes discussed above. Code is ready for review! Yusra and I pair coded other stack removals (of which there happened to be none).
            lskelvin Lee Kelvin added a comment -

            Thanks Trys, this looks good to me. I had some 11th hour concerns that I'd spotted some of this being used by the AP team still, but on closer inspection I think we're fine. In particular, I was distracted by this line:

            from lsst.pipe.tasks.insertFakes import InsertFakesConfig
            

            where insertFakes is this file. That will be removed as part of the v2 fakes code deprecation on DM-37466.

            Thanks for clearing up this very old legacy fakes code Trys, congrats! Happy to see Jenkins complete successfully, and good to merge .

            lskelvin Lee Kelvin added a comment - Thanks Trys, this looks good to me. I had some 11th hour concerns that I'd spotted some of this being used by the AP team still, but on closer inspection I think we're fine. In particular, I was distracted by this line : from lsst.pipe.tasks.insertFakes import InsertFakesConfig where insertFakes is this file . That will be removed as part of the v2 fakes code deprecation on DM-37466 . Thanks for clearing up this very old legacy fakes code Trys, congrats! Happy to see Jenkins complete successfully, and good to merge .
            lskelvin Lee Kelvin added a comment -

            PS, for reference, Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/39075/pipeline/

            (I like to add this link to all my tickets, for quick reference).

            lskelvin Lee Kelvin added a comment - PS, for reference, Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/39075/pipeline/ (I like to add this link to all my tickets, for quick reference).

            People

              trysmccann Trys McCann
              jbosch Jim Bosch
              Lee Kelvin
              Jim Bosch, Lee Kelvin, Trys McCann
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.