Thanks Trys, this looks good to me. I had some 11th hour concerns that I'd spotted some of this being used by the AP team still, but on closer inspection I think we're fine. In particular, I was distracted by this line:
from lsst.pipe.tasks.insertFakes import InsertFakesConfig
where insertFakes is this file. That will be removed as part of the v2 fakes code deprecation on DM-37466.
Thanks for clearing up this very old legacy fakes code Trys, congrats! Happy to see Jenkins complete successfully, and good to merge .