Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34518

Improve reliability of a ts_scriptqueue unit test

    XMLWordPrintable

    Details

    • Story Points:
      0
    • Sprint:
      TSSW Sprint - Apr 25 - May 09
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Fix a few things that I discovered when running ts_scriptqueue with the Kafka version of salobj. The main issue is that one of the unit tests is unreliable due to making unwarrented timing assumptions. The fix is simple (see the u/rowen/kafka branch).

      Also change ScriptQueue.start to call super().start() first instead of last. This is generally a good idea (but requires ts_salobj 7.1) and is needed to use the package with kafka salobj.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/69
            Hide
            rowen Russell Owen added a comment -

            Reviewed on github

            Show
            rowen Russell Owen added a comment - Reviewed on github
            Hide
            rowen Russell Owen added a comment - - edited

            Merged to develop. I will hold off release until I release ts_salobj v7.1 DM-34546

            Show
            rowen Russell Owen added a comment - - edited Merged to develop. I will hold off release until I release ts_salobj v7.1 DM-34546

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Eric Coughlin
              Watchers:
              Eric Coughlin, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.