Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34518

Improve reliability of a ts_scriptqueue unit test

    XMLWordPrintable

    Details

    • Story Points:
      0
    • Sprint:
      TSSW Sprint - Apr 25 - May 09
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Fix a few things that I discovered when running ts_scriptqueue with the Kafka version of salobj. The main issue is that one of the unit tests is unreliable due to making unwarrented timing assumptions. The fix is simple (see the u/rowen/kafka branch).

      Also change ScriptQueue.start to call super().start() first instead of last. This is generally a good idea (but requires ts_salobj 7.1) and is needed to use the package with kafka salobj.

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Story Points 1 0
            rowen Russell Owen made changes -
            Description Fix a few things that I discovered when running ts_scriptqueue with the Kafka version of salobj. The main issue is that one of the unit tests is unreliable due to making unwarrented timing assumptions. The fix is simple (see the u/rowen/kafka branch).

            Also change ScriptQueue.start to call super().start() first instead of last. This requires ts_salobj 7.1.
            Fix a few things that I discovered when running ts_scriptqueue with the Kafka version of salobj. The main issue is that one of the unit tests is unreliable due to making unwarrented timing assumptions. The fix is simple (see the u/rowen/kafka branch).

            Also change ScriptQueue.start to call super().start() first instead of last. This is generally a good idea (but requires ts_salobj 7.1) and is needed to use the package with kafka salobj.
            rowen Russell Owen made changes -
            Reviewers Eric Coughlin [ ecoughlin ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-34546 [ DM-34546 ]

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Eric Coughlin
              Watchers:
              Eric Coughlin, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.