Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34531

Cleanup piff PSF determiner model size config options

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • meas_extensions_piff
    • None
    • 2
    • AP S22-5 (April)
    • Data Release Production
    • No

    Description

      meas_extensions_piff sets the kernelSize parameter in config.setDefaults, but it is not a configurable parameter it has a different meaning in the parent class vs. in piffPsfDeterminer. For DM-34254 (and certainly other things), we need to be able to configure the psf model size. Given the min/max values also used in setDefaults, this is clearly a RangeField. The min/max options in the parent class don't make sense for piff, as they relate to the psf size calculated from the stellar moments.

      For this ticket, I'll make it configurable but keep the current default value of 21.

      Attachments

        Issue Links

          Activity

            Parejkoj John Parejko added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36441/pipeline
            Parejkoj John Parejko added a comment -

            jmeyers314: do you want to take a look? I believe I kept all the functionality, just made kernelSize a configurable field. I don't know if my docstring is correct though.

            Parejkoj John Parejko added a comment - jmeyers314 : do you want to take a look? I believe I kept all the functionality, just made kernelSize a configurable field. I don't know if my docstring is correct though.

            Isn't this already a configurable field via the base class? https://github.com/lsst/meas_algorithms/blob/main/python/lsst/meas/algorithms/psfDeterminer.py#L32

             

            Agree that it could be a RangeField though.

            jmeyers314 Joshua Meyers added a comment - Isn't this already a configurable field via the base class? https://github.com/lsst/meas_algorithms/blob/main/python/lsst/meas/algorithms/psfDeterminer.py#L32   Agree that it could be a RangeField though.

            I just noted that `BasePsfDeterminerTask` requires a `config` arg as its first arg, but that is not a requirement of the API for `Task`s, and in fact `Task` behaves correctly if `config is None`, by creating a default config.

            Parejkoj John Parejko added a comment - I just noted that `BasePsfDeterminerTask` requires a `config` arg as its first arg, but that is not a requirement of the API for `Task`s, and in fact `Task` behaves correctly if `config is None`, by creating a default config.
            Parejkoj John Parejko added a comment - - edited Post cleanup Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36743/pipeline

            Handing this off to kannawad to finish up: this probably requires an RFC, to deprecate those configs for piff.

            Parejkoj John Parejko added a comment - Handing this off to kannawad to finish up: this probably requires an RFC, to deprecate those configs for piff.

            I doubt we want to merge the piff PR (https://github.com/lsst/meas_extensions_piff/pull/9) associated with the ticket. The pex_config PR (https://github.com/lsst/pex_config/pull/71) is already merged, so we should perhaps mark it as Done.

            kannawad Arun Kannawadi added a comment - I doubt we want to merge the piff PR ( https://github.com/lsst/meas_extensions_piff/pull/9 ) associated with the ticket. The pex_config PR ( https://github.com/lsst/pex_config/pull/71 ) is already merged, so we should perhaps mark it as Done.

            People

              kannawad Arun Kannawadi
              Parejkoj John Parejko
              Joshua Meyers
              Arun Kannawadi, Eric Bellm, Ian Sullivan, John Parejko, Joshua Meyers, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.