Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_aos
-
Story Points:5
-
Team:Telescope and Site
Description
Currently, when running
python /project/scichris/aos/ts_phosim/bin.src/imgCloseLoop.py --inst comcam
|
one gets on NCSA lsst_distrib `2022_17`, `ts_phosim` v2.0.1:
INFO:Generating bulter gen3 in /project/scichris/aos/rotation_DM-34424/rot_0/phosimData for comcam |
lsst.LsstCamMapper WARN: Unable to find valid calib root directory
|
lsst.CameraMapper INFO: Loading Posix exposure registry from /project/scichris/aos/rotation_DM-34424/rot_0/phosimData/skydata |
root INFO: Running: /software/lsstsw/stack_20220215/stack/miniconda3-py38_4.9.2-2.0.0/Linux64/pipe_tasks/gb1d6de0934+6a8639994f/bin/ingestReferenceCatalog.py |
/project/scichris/aos/rotation_DM-34424/rot_0/phosimData/skydata /project/scichris/aos/rotation_DM-34424/rot_0/phosimData/skydata/sky_data.csv --configfile |
/project/scichris/aos/rotation_DM-34424/rot_0/phosimData/skydata/cat.cfg |
/software/lsstsw/stack_20220215/stack/miniconda3-py38_4.9.2-2.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/argumentParser.py:782: Futur |
eWarning: Gen2 Butler has been deprecated (Butler). It will be removed sometime after v23.0 but no earlier than the end of 2021. |
namespace.butler = dafPersist.Butler(outputs=outputs)
|
/software/lsstsw/stack_20220215/stack/miniconda3-py38_4.9.2-2.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/argumentParser.py:782: Futur |
eWarning: Gen2 Butler has been deprecated (LsstCamMapper). It will be removed sometime after v23.0 but no earlier than the end of 2021. |
namespace.butler = dafPersist.Butler(outputs=outputs)
|
IngestIndexedReferenceTask INFO: Creating 131072 file locks. |
IngestIndexedReferenceTask INFO: File locks created.
|
IngestIndexedReferenceTask INFO: Completed 1 / 1 files: 100 % complete |
root WARN: Unable to retrieve exit status ('NoneType' object is not iterable); assuming success |
py.warnings WARNING: /software/lsstsw/stack_20220215/stack/miniconda3-py38_4.9.2-2.0.0/Linux64/daf_butler/gb7ebdee0ea+6728436f39/python/lsst/daf/butler/cli/u |
tils.py:901: FutureWarning: Gen2 Butler has been deprecated (Butler). It will be removed sometime after v23.0 but no earlier than the end of 2021. |
func(*args, **kwargs)
|
|
|
|
|
py.warnings WARNING: /software/lsstsw/stack_20220215/stack/miniconda3-py38_4.9.2-2.0.0/Linux64/daf_butler/gb7ebdee0ea+6728436f39/python/lsst/daf/butler/cli/u |
tils.py:901: FutureWarning: Gen2 Butler has been deprecated (LsstCamMapper). It will be removed sometime after v23.0 but no earlier than the end of 2021. |
func(*args, **kwargs)
|
...
|
This is connected to `GenerateRefCatalog` https://github.com/lsst-ts/ts_phosim/blob/4172fa9eb23b30ef4b85684cc3d6ddf188cc9f55/python/lsst/ts/phosim/CloseLoopTask.py#L1372 which currently creates the reference catalog using Gen2 butler and then converts it to Gen3. This ticket is to remove the Gen2 dependency so that deprecation warning would not be triggered.
Attachments
Issue Links
Activity
Tim Jenness is there a date at which Gen 2 reference catalog support will no long work in the stack (as opposed to generating deprecation warnings). We want to set a priority on this work
In theory the date is any time with no notice.
I was about to remove all gen2 support from obs_lsst which would, of course, break your code completely but I can delay that for a bit (I think this must be the last user of gen2 obs_lsst code since the commissioning team are now using gen3).
A notebook explaining the upgraded parts
https://github.com/suberlak/AOS/blob/main/AOS_DM-34547_refcats_ts_phosim.ipynb
After the upgrade the loop converges. Attached is the result of running
python /project/scichris/aos/ts_phosim/bin.src/imgCloseLoop.py --inst comcam --numOfProc 15 --boresightDeg 0.0 0.0 --output /project/scichris/aos/refcats_DM-34547/imgCloseLoop/ |
Opened a PR on github; the loop converges as before and tests pass.
Reviewed on Github
Merged and closed the ticket
If you haven't found it yet this might help: https://pipelines.lsst.io/v/weekly/modules/lsst.meas.algorithms/creating-a-reference-catalog.html