Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34557

Reinstate the missing ATWhiteLight ChillerL22Alarms enum value

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      TSSW Sprint - Apr 25 - May 09
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      The level22 field of the ATWhiteLight chillerAlarms event represents a bitmask that has 32 bits. This caused a bit of trouble for ts_sal: DM-34005, which Dave Mills has kindly fixed. I originally worked around it by omitting the last ChillerL22Alarms value. Update ts_xml to reinstate the value and specify the enum type as "unsigned int" or "unsigned long" (which are identical – both 32 bits).

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue relates to DM-34005 [ DM-34005 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-34561 [ DM-34561 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-34563 [ DM-34563 ]
            rowen Russell Owen made changes -
            Link This issue is child task of CAP-878 [ CAP-878 ]
            rowen Russell Owen made changes -
            Summary Split ATWhiteLight chillerAlarms.level22 into two pieces Reinstate the missing ATWhiteLight ChillerL22Alarms enum value
            rowen Russell Owen made changes -
            Link This issue relates to DM-34563 [ DM-34563 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-34561 [ DM-34561 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-34005 [ DM-34005 ]
            rowen Russell Owen made changes -
            Link This issue is triggered by DM-34005 [ DM-34005 ]
            rowen Russell Owen made changes -
            Description The level22 field of the ATWhiteLight chillerAlarms event represents a bitmask that has 64 bits. This causes a bit of trouble for ts_sal (DM-34005, which [~dmills] has kindly fixed) but it is also be problematic for the EFD, because that is loaded from Kafka messages described by Avro schemas and the longest integer that Avro supports is {{long}}: signed 64 bits. Avro has no support for unsigned integers.

            So: split this bitmask into two pieces, each 32 bits long

            Also update ts_xml to make the types of those bit mask fields {{long}} instead of {{unsigned int}}.
            The level22 field of the ATWhiteLight chillerAlarms event represents a bitmask that has 32 bits. This caused a bit of trouble for ts_sal: DM-34005, which [~dmills] has kindly fixed. I originally worked around it by omitting the last ChillerL22Alarms value. Update ts_xml to reinstate the value and specify the enum type as "unsigned int" or "unsigned long" (which are identical -- both 32 bits).
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Reviewers Petr Kubanek [ pkubanek ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Link This issue is blocked by DM-34567 [ DM-34567 ]
            rowen Russell Owen made changes -
            Status In Progress [ 3 ] To Do [ 10001 ]
            rowen Russell Owen made changes -
            Story Points 2 1
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            pkubanek Petr Kubanek made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Petr Kubanek
              Watchers:
              Petr Kubanek, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.