Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_diffim
-
Labels:
-
Story Points:1
-
Epic Link:
-
Team:Alert Production
-
Urgent?:No
Description
Running the diffim tests produces a variety of FutureWarnings. I've pasted a sample below, but we should try to clean all of them up.
/home/parejkoj/lsst/repos/ip_diffim/python/lsst/ip/diffim/dcrModel.py:662: DeprecationWarning: Please use `binary_opening` from the `scipy.ndimage` namespace, the `scipy.ndimage.morphology` namespace is deprecated.
|
lowPixels = ndimage.morphology.binary_opening(lowPixels, structure=filterStructure)
|
|
|
|
|
/home/parejkoj/lsst/repos/ip_diffim/python/lsst/ip/diffim/dcrModel.py:577: DeprecationWarning: Please use `gaussian_filter` from the `scipy.ndimage` namespace, the `scipy.ndimage.filters` namespace is deprecated.
|
smoothModel = ndimage.filters.gaussian_filter(model.array, filterWidth, mode='constant')
|
|
|
tests/test_dipole.py: 11 warnings
|
/home/parejkoj/lsst/repos/ip_diffim/tests/test_dipole.py:80: FutureWarning: Default position argument overload is deprecated and will be removed in version 24.0. Please explicitly specify a position.
|
psfim = psf.computeImage().convertF()
|
|
|
/home/parejkoj/lsst/repos/ip_diffim/python/lsst/ip/diffim/imageMapReduce.py:297: DeprecationWarning: `np.float` is a deprecated alias for the builtin `float`. To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
|
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
|
wts = weights.getArray().astype(np.float)
|
|
|
/home/parejkoj/lsst/repos/ip_diffim/python/lsst/ip/diffim/imageDecorrelation.py:741: FutureWarning: Call to deprecated method getLevel. (Use Python Logger compatible .level property. Will be removed after v23.) -- Deprecated since version v23.
|
logLevel = self.log.getLevel()
|
|
|
/home/parejkoj/lsst/repos/ip_diffim/python/lsst/ip/diffim/zogy.py:292: FutureWarning: Default position argument overload is deprecated and will be removed in version 24.0. Please explicitly specify a position.
|
psfBBox1 = psf1.computeBBox()
|
|
|
/home/parejkoj/lsst/repos/ip_diffim/python/lsst/ip/diffim/modelPsfMatch.py:419: FutureWarning: Default position argument overload is deprecated and will be removed in version 24.0. Please explicitly specify a position.
|
dimenR = referencePsfModel.getLocalKernel().getDimensions()
|
Erin and I worked on this at pair coding today. I think we got all the easy warnings out of the way, the rest are either internal to flake8 or are the psf position ones that are being fixed on another ticket.
Ian Sullivan: are you able to review this minor change? If not, we can find someone else.