Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34612

Call super().start() first in RO's CSCs that override start

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Apr 25 - May 09
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Call super().start() first in RO's CSCs that override the start method (which is most of them)

      This is not necessary, but is good practice. It requires ts_salobj 7.1

      For packages updated for this also add asyncio_mode = auto to setup.cfg and .hypotheses to .gitignore

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34546 Release RO packages for cycle 26

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rowen Russell Owen created issue -
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Pull requests (I also modernized the Jenkinsfile for all but ts_atwhitelight, for which it had already been done):

            The following need no update:

            • ts_ATDome (already called first)
            • ts_ATDomeTrajectory (already called first)
            • ts_authorize (no start method)
            • ts_FiberSpectrograph (no start method)
            • ts_ess_csc (no start method)
            • ts_hexrotcomm (no start method)
            • ts_mtdometrajectory (already called first)
            • ts_scriptqueue (already updated, though not released)
            • ts_watcher (no start method)
            Show
            rowen Russell Owen added a comment - - edited Pull requests (I also modernized the Jenkinsfile for all but ts_atwhitelight, for which it had already been done): https://github.com/lsst-ts/ts_ATMCSSimulator/pull/35 https://github.com/lsst-ts/ts_ATPneumaticsSimulator/pull/18 https://github.com/lsst-ts/ts_atwhitelight/pull/14 https://github.com/lsst-ts/ts_mthexapod/pull/66 https://github.com/lsst-ts/ts_mtmount/pull/70 https://github.com/lsst-ts/ts_mtrotator/pull/63 The following need no update: ts_ATDome (already called first) ts_ATDomeTrajectory (already called first) ts_authorize (no start method) ts_FiberSpectrograph (no start method) ts_ess_csc (no start method) ts_hexrotcomm (no start method) ts_mtdometrajectory (already called first) ts_scriptqueue (already updated, though not released) ts_watcher (no start method)
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-27719 [ 442124 ]
            Sprint TSSW Sprint - Apr 25 - May 09 [ 1163 ]
            Labels ts_ATMCSSimulator ts_ATPneumaticsSimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Description Call super().start() first in RO's CSCs that override the start method (which is most of them)

            This is not necessary, but is good practice. It requires ts_salobj 7.1             		Call super().start() first in RO's CSCs that override the start method (which is most of them)

            This is not necessary, but is good practice. It requires ts_salobj 7.1

            For packages updated for this also add asyncio_mode = auto to setup.cfg and .hypotheses to .gitignore
            rowen Russell Owen made changes -
            Reviewers Eric Coughlin [ ecoughlin ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            ecoughlin Eric Coughlin added a comment -

            Reviewed in GitHub.

            Show
            ecoughlin Eric Coughlin added a comment - Reviewed in GitHub.
            ecoughlin Eric Coughlin made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Merged to develop:

            • ts_ATMCSSimulator
            • ts_ATPneumaticsSimulator
            • ts_atwhitelight
            • ts_mthexapod
            • ts_mtmount
            • ts_mtrotator

            Release will be done using DM-34546

            Show
            rowen Russell Owen added a comment - - edited Merged to develop: ts_ATMCSSimulator ts_ATPneumaticsSimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator Release will be done using DM-34546
            rowen Russell Owen made changes -
            Link This issue relates to DM-34546 [ DM-34546 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            rowen Russell Owen made changes -
            Labels ts_ATMCSSimulator ts_ATPneumaticsSimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator ts_ATMCSSimulator ts_ATPneumaticsSimulator ts_atpneumaticsimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator
            rowen Russell Owen made changes -
            Labels ts_ATMCSSimulator ts_ATPneumaticsSimulator ts_atpneumaticsimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator ts_ATMCSSimulator ts_atpneumaticsimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator
            rowen Russell Owen made changes -
            Labels ts_ATMCSSimulator ts_atpneumaticsimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator ts_ATMCSSimulator ts_atmcssimulator ts_atpneumaticsimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator
            rowen Russell Owen made changes -
            Labels ts_ATMCSSimulator ts_atmcssimulator ts_atpneumaticsimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator ts_atmcssimulator ts_atpneumaticsimulator ts_atwhitelight ts_mthexapod ts_mtmount ts_mtrotator

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Eric Coughlin
              Watchers:
              Eric Coughlin, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.