Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34698

Default piff kernelSize to 25

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Urgent?:
      No

      Description

      DM-34254 changed the piff kernelSize to 25 in ap_pipe, but left it unchanged for drp at the request of that team. This ticket is to change the default kernelSize in meas_extensions_piff to 25 and remove the ap_pipe override.

      Note that it also will also require modifying the default kernelSize for candidates in MeasurePsfTask to match.

        Attachments

          Issue Links

          is triggered by

          Bug - A problem which impairs or prevents the functions of the product. DM-34254 ap_verify metrics report 0 completeness after switch to Piff

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34531 Cleanup piff PSF determiner model size config options

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35870 Enable PSF padding by default in computeApertureFlux

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-861 Clean up PsfDeterminer configs

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment - - edited

            I am yet to check this thoroughly, but it looked like setting kernelSize=25 results in failiure in step2 of the DRP pipeline.

            Show
            kannawad Arun Kannawadi added a comment - - edited I am yet to check this thoroughly, but it looked like setting kernelSize=25 results in failiure in step2 of the DRP pipeline.
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            May be that's because I didn't make corresponding changes in MeasurePsfTask may be?

            Show
            kannawad Arun Kannawadi added a comment - May be that's because I didn't make corresponding changes in MeasurePsfTask may be?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            A question Arun Kannawadi and I came up with while looking into things: Should we pass `drawSize` to piffConfig as the `size` parameter, instead of `kernelSize`?

            Show
            Parejkoj John Parejko added a comment - A question Arun Kannawadi and I came up with while looking into things: Should we pass `drawSize` to piffConfig as the `size` parameter, instead of `kernelSize`?
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            The ticket changes the size in meas_extensions_piff and in makePsfCandidatesTask, rather than letting meas_extensions_piff change it, as PSFEx and PCA PSFs were doing. This is done with RFC-861 in mind.

             

            Jenkins has passed: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36773/pipeline

            Show
            kannawad Arun Kannawadi added a comment - The ticket changes the size in meas_extensions_piff and in makePsfCandidatesTask, rather than letting meas_extensions_piff change it, as PSFEx and PCA PSFs were doing. This is done with RFC-861 in mind.   Jenkins has passed:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36773/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Please also remove the lines in ap_pipe that I added in DM-34254.

            https://github.com/lsst/ap_pipe/search?q=kernelSize

            Show
            Parejkoj John Parejko added a comment - Please also remove the lines in ap_pipe that I added in DM-34254 . https://github.com/lsst/ap_pipe/search?q=kernelSize
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            Thanks John. Done that, and addressed other comments on Github. Kicked off another Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36778/pipeline

            Show
            kannawad Arun Kannawadi added a comment - Thanks John. Done that, and addressed other comments on Github. Kicked off another Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36778/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            There was one remaining question on the pipelines_check PR, otherwise I think this is good to go. Thanks for taking care of it.

            Show
            Parejkoj John Parejko added a comment - There was one remaining question on the pipelines_check PR, otherwise I think this is good to go. Thanks for taking care of it.
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            The comment says whether the changes to the values in pipelines_check are reasonable should happen in #dm-science-pipelines. Here's the thread for that conversation: https://lsstc.slack.com/archives/C2JPMCF5X/p1654615446782619

            Show
            kannawad Arun Kannawadi added a comment - The comment says whether the changes to the values in pipelines_check are reasonable should happen in #dm-science-pipelines. Here's the thread for that conversation:  https://lsstc.slack.com/archives/C2JPMCF5X/p1654615446782619

              People

              Assignee:
              kannawad Arun Kannawadi
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              John Parejko
              Watchers:
              Arun Kannawadi, Eric Bellm, John Parejko, Joshua Meyers, Lee Kelvin, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.