Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34698

Default piff kernelSize to 25

    XMLWordPrintable

Details

    • 2
    • No

    Description

      DM-34254 changed the piff kernelSize to 25 in ap_pipe, but left it unchanged for drp at the request of that team. This ticket is to change the default kernelSize in meas_extensions_piff to 25 and remove the ap_pipe override.

      Note that it also will also require modifying the default kernelSize for candidates in MeasurePsfTask to match.

      Attachments

        Issue Links

          Activity

            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue is triggered by DM-34254 [ DM-34254 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-34531 [ DM-34531 ]
            kannawad Arun Kannawadi added a comment - - edited

            I am yet to check this thoroughly, but it looked like setting kernelSize=25 results in failiure in step2 of the DRP pipeline.

            kannawad Arun Kannawadi added a comment - - edited I am yet to check this thoroughly, but it looked like setting kernelSize=25 results in failiure in step2 of the DRP pipeline.

            May be that's because I didn't make corresponding changes in MeasurePsfTask may be?

            kannawad Arun Kannawadi added a comment - May be that's because I didn't make corresponding changes in MeasurePsfTask may be?

            A question kannawad and I came up with while looking into things: Should we pass `drawSize` to piffConfig as the `size` parameter, instead of `kernelSize`?

            Parejkoj John Parejko added a comment - A question kannawad and I came up with while looking into things: Should we pass `drawSize` to piffConfig as the `size` parameter, instead of `kernelSize`?
            kannawad Arun Kannawadi made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            kannawad Arun Kannawadi made changes -
            Assignee Arun Kannawadi [ kannawad ]

            The ticket changes the size in meas_extensions_piff and in makePsfCandidatesTask, rather than letting meas_extensions_piff change it, as PSFEx and PCA PSFs were doing. This is done with RFC-861 in mind.

             

            Jenkins has passed: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36773/pipeline

            kannawad Arun Kannawadi added a comment - The ticket changes the size in meas_extensions_piff and in makePsfCandidatesTask, rather than letting meas_extensions_piff change it, as PSFEx and PCA PSFs were doing. This is done with RFC-861 in mind.   Jenkins has passed:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36773/pipeline
            kannawad Arun Kannawadi made changes -
            Reviewers John Parejko [ parejkoj ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            kannawad Arun Kannawadi made changes -
            Link This issue relates to RFC-861 [ RFC-861 ]

            Please also remove the lines in ap_pipe that I added in DM-34254.

            https://github.com/lsst/ap_pipe/search?q=kernelSize

            Parejkoj John Parejko added a comment - Please also remove the lines in ap_pipe that I added in DM-34254 . https://github.com/lsst/ap_pipe/search?q=kernelSize

            Thanks John. Done that, and addressed other comments on Github. Kicked off another Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36778/pipeline

            kannawad Arun Kannawadi added a comment - Thanks John. Done that, and addressed other comments on Github. Kicked off another Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36778/pipeline
            Parejkoj John Parejko added a comment -

            There was one remaining question on the pipelines_check PR, otherwise I think this is good to go. Thanks for taking care of it.

            Parejkoj John Parejko added a comment - There was one remaining question on the pipelines_check PR, otherwise I think this is good to go. Thanks for taking care of it.
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]

            The comment says whether the changes to the values in pipelines_check are reasonable should happen in #dm-science-pipelines. Here's the thread for that conversation: https://lsstc.slack.com/archives/C2JPMCF5X/p1654615446782619

            kannawad Arun Kannawadi added a comment - The comment says whether the changes to the values in pipelines_check are reasonable should happen in #dm-science-pipelines. Here's the thread for that conversation:  https://lsstc.slack.com/archives/C2JPMCF5X/p1654615446782619
            kannawad Arun Kannawadi made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            lskelvin Lee Kelvin made changes -
            Link This issue relates to DM-35870 [ DM-35870 ]

            People

              kannawad Arun Kannawadi
              Parejkoj John Parejko
              John Parejko
              Arun Kannawadi, Eric Bellm, John Parejko, Joshua Meyers, Lee Kelvin, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.