Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34699

Patch the ap_pipe config reset hack

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • ap_pipe
    • None
    • 2
    • AP S22-6 (May)
    • Alert Production
    • No

    Description

      While investigating why the solution to DM-34254 only needs config overrides in the root ApPipe pipeline, I discovered that the hack I'd introduced in DM-31063 blocks its own config settings, not the obs package config's. This is not what we want for cleaning up the AP pipeline configuration.

      Find an improved version of the hack that actually resets the pipeline's config. Preliminary experiments have gotten good results with Config.loadFromString and Config.saveToString, but I have not yet tested how this works with configs that may require imports or otherwise alter nested configs.

      Attachments

        Issue Links

          Activity

            Hi Parejkoj, since this issue is relevant to both DM-31063 and DM-34254, would you be willing to review it? It's 70 lines total.

            krzys Krzysztof Findeisen added a comment - Hi Parejkoj , since this issue is relevant to both DM-31063 and DM-34254 , would you be willing to review it? It's 70 lines total.

            I'm not seeing the PRs for this linked?

            Parejkoj John Parejko added a comment - I'm not seeing the PRs for this linked?
            krzys Krzysztof Findeisen added a comment - It's ap_pipe#108 .

            People

              krzys Krzysztof Findeisen
              krzys Krzysztof Findeisen
              John Parejko
              Eric Bellm, Ian Sullivan, John Parejko, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.