Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34752

Move non-generic characterize/calibrate configs out of obs_lsst/config

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_pipe, obs_lsst
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S22-6 (May)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      While reviewing DM-32141, we noticed that the base-level obs_lsst configs have a mix of HSC- and simulation-specific values. In particular, the refcats in calibrate and characterizeImage are `cal_ref_cat`, which is the old "default" name and was used for the simulations, but is wrong for everything else. With DM-27013 merged, the refcat defaults for those tasks are now correct for everything except the simulations, so we shouldn't be overriding things unless we need to.

      This ticket is to move the simulation-specific overrides out of those files and into the imsim/phosim configs, and also to cleanup similar configs in ap_pipe post-DM-31063.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32141 Get AuxTel SFM reductions working end-to-end

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27013 Change CalibrateTask refcat defaults to Gaia DR2 for astrometry and PS1 for photometry

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31063 Copy configs from obs_* packages to ap_pipe

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34768 Deprecate characterizeImage refcat hooks

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Nate Lust: Can you please review this trivial readme change in ci_imsim?

            https://github.com/lsst/ci_imsim/pull/22

            Merlin Fisher-Levine: Can you please check whether the obs_lsst change works for you for LATISS? We might not know the full answer until we merge this and then try to make the DM-32141 changes on top of it.

            https://github.com/lsst/obs_lsst/pull/398

            Show
            Parejkoj John Parejko added a comment - Nate Lust : Can you please review this trivial readme change in ci_imsim? https://github.com/lsst/ci_imsim/pull/22 Merlin Fisher-Levine : Can you please check whether the obs_lsst change works for you for LATISS? We might not know the full answer until we merge this and then try to make the DM-32141 changes on top of it. https://github.com/lsst/obs_lsst/pull/398
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins run with ci_imsim (I got a successful local ci_imsim run first): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins run with ci_imsim (I got a successful local ci_imsim run first): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            Code looks good. Plenty of OOB communication about testing and DM-32141 being redone, which I'll leave there, but I think this is good to go as long as Erik Dennihy is happy.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Code looks good. Plenty of OOB communication about testing and DM-32141 being redone, which I'll leave there, but I think this is good to go as long as Erik Dennihy is happy.
            Hide
            Permalink
            edennihy Erik Dennihy added a comment -

            Yes, this is all fine with me. I'll work on the changes needed to get DM-32141 working again once merged.

            Show
            edennihy Erik Dennihy added a comment - Yes, this is all fine with me. I'll work on the changes needed to get DM-32141 working again once merged.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            New Jenkins run with a fixed version of Merlin Fisher-Levine's change to not always run expensive plugins in characterize: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline/

            Show
            Parejkoj John Parejko added a comment - New Jenkins run with a fixed version of Merlin Fisher-Levine 's change to not always run expensive plugins in characterize: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline/
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            And one more, having removed Merlin's change because I couldn't get it to work with ci_imsim: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36571/pipeline

            Show
            Parejkoj John Parejko added a comment - And one more, having removed Merlin's change because I couldn't get it to work with ci_imsim: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36571/pipeline

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Merlin Fisher-Levine, Nate Lust
              Watchers:
              Erik Dennihy, Ian Sullivan, John Parejko, Merlin Fisher-Levine
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.