Fix Version/s: None
Sprint:AP S22-6 (May)
DM-32141, we noticed that the base-level obs_lsst configs have a mix of HSC- and simulation-specific values. In particular, the refcats in calibrate and characterizeImage are `cal_ref_cat`, which is the old "default" name and was used for the simulations, but is wrong for everything else. With DM-27013 merged, the refcat defaults for those tasks are now correct for everything except the simulations, so we shouldn't be overriding things unless we need to.
This ticket is to move the simulation-specific overrides out of those files and into the imsim/phosim configs, and also to cleanup similar configs in ap_pipe post-
Jenkins run with ci_imsim (I got a successful local ci_imsim run first): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline
Code looks good. Plenty of OOB communication about testing and
DM-32141 being redone, which I'll leave there, but I think this is good to go as long as Erik Dennihy is happy.
Yes, this is all fine with me. I'll work on the changes needed to get
DM-32141 working again once merged.
New Jenkins run with a fixed version of Merlin Fisher-Levine's change to not always run expensive plugins in characterize: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline/
And one more, having removed Merlin's change because I couldn't get it to work with ci_imsim: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36571/pipeline
Nate Lust: Can you please review this trivial readme change in ci_imsim?
Merlin Fisher-Levine: Can you please check whether the obs_lsst change works for you for LATISS? We might not know the full answer until we merge this and then try to make the
DM-32141changes on top of it.