Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34752

Move non-generic characterize/calibrate configs out of obs_lsst/config

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • ap_pipe, obs_lsst
    • None
    • 1
    • AP S22-6 (May)
    • Alert Production
    • No

    Description

      While reviewing DM-32141, we noticed that the base-level obs_lsst configs have a mix of HSC- and simulation-specific values. In particular, the refcats in calibrate and characterizeImage are `cal_ref_cat`, which is the old "default" name and was used for the simulations, but is wrong for everything else. With DM-27013 merged, the refcat defaults for those tasks are now correct for everything except the simulations, so we shouldn't be overriding things unless we need to.

      This ticket is to move the simulation-specific overrides out of those files and into the imsim/phosim configs, and also to cleanup similar configs in ap_pipe post-DM-31063.

      Attachments

        Issue Links

          Activity

            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue is triggered by DM-32141 [ DM-32141 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-31063 [ DM-31063 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-27013 [ DM-27013 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30506 [ 510172 ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]

            nlust: Can you please review this trivial readme change in ci_imsim?

            https://github.com/lsst/ci_imsim/pull/22

            mfisherlevine: Can you please check whether the obs_lsst change works for you for LATISS? We might not know the full answer until we merge this and then try to make the DM-32141 changes on top of it.

            https://github.com/lsst/obs_lsst/pull/398

            Parejkoj John Parejko added a comment - nlust : Can you please review this trivial readme change in ci_imsim? https://github.com/lsst/ci_imsim/pull/22 mfisherlevine : Can you please check whether the obs_lsst change works for you for LATISS? We might not know the full answer until we merge this and then try to make the DM-32141 changes on top of it. https://github.com/lsst/obs_lsst/pull/398
            Parejkoj John Parejko made changes -
            Reviewers Merlin Fisher-Levine, Nate Lust [ mfisherlevine, nlust ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Parejkoj John Parejko added a comment - - edited

            Jenkins run with ci_imsim (I got a successful local ci_imsim run first): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline

            Parejkoj John Parejko added a comment - - edited Jenkins run with ci_imsim (I got a successful local ci_imsim run first): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline

            Code looks good. Plenty of OOB communication about testing and DM-32141 being redone, which I'll leave there, but I think this is good to go as long as edennihy is happy.

            mfisherlevine Merlin Fisher-Levine added a comment - Code looks good. Plenty of OOB communication about testing and DM-32141 being redone, which I'll leave there, but I think this is good to go as long as edennihy is happy.
            mfisherlevine Merlin Fisher-Levine made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            edennihy Erik Dennihy added a comment -

            Yes, this is all fine with me. I'll work on the changes needed to get DM-32141 working again once merged.

            edennihy Erik Dennihy added a comment - Yes, this is all fine with me. I'll work on the changes needed to get DM-32141 working again once merged.
            nlust Nate Lust made changes -
            Watchers Erik Dennihy, Ian Sullivan, John Parejko, Merlin Fisher-Levine, Nate Lust [ Erik Dennihy, Ian Sullivan, John Parejko, Merlin Fisher-Levine, Nate Lust ] Erik Dennihy, Ian Sullivan, John Parejko, Merlin Fisher-Levine [ Erik Dennihy, Ian Sullivan, John Parejko, Merlin Fisher-Levine ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-34768 [ DM-34768 ]
            Parejkoj John Parejko added a comment -

            New Jenkins run with a fixed version of mfisherlevine's change to not always run expensive plugins in characterize: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline/

            Parejkoj John Parejko added a comment - New Jenkins run with a fixed version of mfisherlevine 's change to not always run expensive plugins in characterize: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36566/pipeline/
            Parejkoj John Parejko added a comment -

            And one more, having removed Merlin's change because I couldn't get it to work with ci_imsim: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36571/pipeline

            Parejkoj John Parejko added a comment - And one more, having removed Merlin's change because I couldn't get it to work with ci_imsim: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36571/pipeline
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Merlin Fisher-Levine, Nate Lust
              Erik Dennihy, Ian Sullivan, John Parejko, Merlin Fisher-Levine
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.