Fix Version/s: None
Component/s: ip_diffim, meas_algorithms, meas_base, meas_deblender, meas_extensions_scarlet
Team:Data Release Production
When the psf computeShape routines were deprecated originally the incorrect usage was not removed. Looking through logs the following lines need to be fixed:
These should use the average position:
This should use the footprint position (and docstring updated):
This should use the bbox center:
There are also tests in meas_algorithms that need to be updated. Also c++ usage such as (these show up as compile time warnings):
And looking through afw, and definitely afw tests re: trampolines.
- is blocked by
DM-34777 Scarlet should take in a position to compute PSF image
- is triggered by
RFC-796 Default Psf position argument considered harmful
- is triggering
DM-35552 Look into "cannot convert float NaN to integer" in calibrate's meas_deblender call
- mentioned in
Eli Rykoff, is this good to merge?
All good from my end, but do we need Ian Sullivan to look at https://github.com/lsst/ip_diffim/pull/215 ?
Yeah, it'd be good if Ian Sullivan could take a look at the 1-line commit in the PR and confirm that this is the intended use case.
For the record, the two places where we evaluate the PSF not at the "average position" is in meas_base and in meas_deblender.
Jenkins passed - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36609/pipeline
A couple more: