Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34770

Remove deprecated uses of psf computeShape() and friends

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      DRP S22B
    • Team:
      Data Release Production
    • Urgent?:
      No

      Attachments

        Issue Links

        is blocked by

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34777 Scarlet should take in a position to compute PSF image

        • Done
        is triggered by

        RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-796 Default Psf position argument considered harmful

        • Adopted
        is triggering

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35552 Look into "cannot convert float NaN to integer" in calibrate's meas_deblender call

        • Done
        mentioned in

        Page Loading...

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          A couple more:

          https://github.com/lsst/meas_extensions_scarlet/blob/746e97fe6b17aff4d1f5eab0b738c47a0b223aa3/python/lsst/meas/extensions/scarlet/scarletDeblendTask.py#L94
          https://github.com/lsst/meas_extensions_scarlet/blob/746e97fe6b17aff4d1f5eab0b738c47a0b223aa3/python/lsst/meas/extensions/scarlet/scarletDeblendTask.py#L126

          Show
          erykoff Eli Rykoff added a comment - A couple more: https://github.com/lsst/meas_extensions_scarlet/blob/746e97fe6b17aff4d1f5eab0b738c47a0b223aa3/python/lsst/meas/extensions/scarlet/scarletDeblendTask.py#L94 https://github.com/lsst/meas_extensions_scarlet/blob/746e97fe6b17aff4d1f5eab0b738c47a0b223aa3/python/lsst/meas/extensions/scarlet/scarletDeblendTask.py#L126
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          Jenkins is ongoing: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36580/pipeline

          Show
          kannawad Arun Kannawadi added a comment - Jenkins is ongoing:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36580/pipeline
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          Jenkins passed.

          https://ci.lsst.codes/job/stack-os-matrix/36586/display/redirect

          Eli Rykoff, is this good to merge?

          Show
          kannawad Arun Kannawadi added a comment - Jenkins passed. https://ci.lsst.codes/job/stack-os-matrix/36586/display/redirect Eli Rykoff , is this good to merge?
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          All good from my end, but do we need Ian Sullivan to look at https://github.com/lsst/ip_diffim/pull/215 ?

          Show
          erykoff Eli Rykoff added a comment - All good from my end, but do we need Ian Sullivan to look at https://github.com/lsst/ip_diffim/pull/215 ?
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          Yeah, it'd be good if Ian Sullivan could take a look at the 1-line commit in the PR and confirm that this is the intended use case.

          Show
          kannawad Arun Kannawadi added a comment - Yeah, it'd be good if Ian Sullivan  could take a look at the 1-line commit in the PR and confirm that this is the intended use case.
          Hide
          Permalink
          sullivan Ian Sullivan added a comment -

          Looks fine to me.

          Show
          sullivan Ian Sullivan added a comment - Looks fine to me.
          Hide
          Permalink
          kannawad Arun Kannawadi added a comment -

          For the record, the two places where we evaluate the PSF not at the "average position" is in meas_base and in meas_deblender.

           

          Jenkins passed - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36609/pipeline

          Show
          kannawad Arun Kannawadi added a comment - For the record, the two places where we evaluate the PSF not at the "average position" is in meas_base and in meas_deblender.   Jenkins passed - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36609/pipeline

            People

            Assignee:
            kannawad Arun Kannawadi
            Reporter:
            erykoff Eli Rykoff
            Reviewers:
            Eli Rykoff
            Watchers:
            Arun Kannawadi, Eli Rykoff, Ian Sullivan, John Parejko
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.