Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34772

Recommend properties-file contents for DP0.2 HiPS maps

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Data Access
    • Labels:
    • Story Points:
      2
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      The HiPS standard states that HiPS image maps should have a properties file in their file tree, carrying a variety of mandatory, recommended, and optional information about the image.

      The task in this ticket is to provide recommendations for the content of this file for the HiPS maps to be produced as part of DP0.2.

        Attachments

          Issue Links

            Activity

            No builds found.
            gpdf Gregory Dubois-Felsmann created issue -
            gpdf Gregory Dubois-Felsmann made changes -
            Field Original Value New Value
            Link This issue is FF-depended by DM-34689 [ DM-34689 ]
            gpdf Gregory Dubois-Felsmann made changes -
            Remote Link This issue links to "HiPS standard v1.0 (Web Link)" [ 33028 ]
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            Eli Rykoff What have you ended up doing for the em_min / em_max attributes? Something like the ad-hoc table that Andy Salnikov uses for the ObsCore extraction in dax_obscore/config/dp02.yaml?

            Show
            gpdf Gregory Dubois-Felsmann added a comment - Eli Rykoff What have you ended up doing for the em_min / em_max attributes? Something like the ad-hoc table that Andy Salnikov uses for the ObsCore extraction in dax_obscore/config/dp02.yaml ?
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            Eli Rykoff Would you code be able to provide multiple instances of prov_progenitor in the file (that's standards-consistent - see the "*" on page 18 of the standard) or is the output based on a dict and so only allowing one instance of each keyword?

            Show
            gpdf Gregory Dubois-Felsmann added a comment - Eli Rykoff Would you code be able to provide multiple instances of prov_progenitor in the file (that's standards-consistent - see the "*" on page 18 of the standard) or is the output based on a dict and so only allowing one instance of each keyword?
            Hide
            erykoff Eli Rykoff added a comment -

            For em_min/em_max I just put in dummy variables so far. If this is vital I can add it, with a hacky ad-hoc config dict.

            For prov_progenitor I just have a freeform text field that you can put in the config. If it needs to be per-band I can change that configuration variable. But if it should be some cookie-cutter template that the band is substituted in (this is my plan for the creator_did for example), then that's even better.

            Show
            erykoff Eli Rykoff added a comment - For em_min / em_max I just put in dummy variables so far. If this is vital I can add it, with a hacky ad-hoc config dict. For prov_progenitor I just have a freeform text field that you can put in the config. If it needs to be per-band I can change that configuration variable. But if it should be some cookie-cutter template that the band is substituted in (this is my plan for the creator_did for example), then that's even better.
            gpdf Gregory Dubois-Felsmann made changes -
            Attachment hips-properties-recommendation.txt [ 60468 ]
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            At last - properties recommendations attached: hips-properties-recommendation.txt

            Show
            gpdf Gregory Dubois-Felsmann added a comment - At last - properties recommendations attached: hips-properties-recommendation.txt
            gpdf Gregory Dubois-Felsmann made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            gpdf Gregory Dubois-Felsmann made changes -
            Reviewers Eli Rykoff [ erykoff ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            erykoff Eli Rykoff added a comment -

            Thanks! To be clear there should be multiple entries for prov_progenitor, and not one long entry?

            Show
            erykoff Eli Rykoff added a comment - Thanks! To be clear there should be multiple entries for prov_progenitor , and not one long entry?
            Hide
            gpdf Gregory Dubois-Felsmann added a comment - - edited
            1. em_min / em_max: it's not "vital", to be sure, but it seems reasonable to be consistent with the em_min / em_max we're reporting in the ObsCore table for the input images.
            2. prov_progenitor: yes, multiple instances is clearly what the standard envisions:

            Some keywords may be repeated to specify multiple values like provenance (suggested by (*) in the following table).

            Keyword Req or Should Description - Format - Example
            prov_progenitor (*) S Provenance of the original data - Format: free text

            However, if this is architecturally difficult, because your whole code is based on a dict, say, I'm OK if you concatenate them all, perhaps with semicolons, for now.

            A template with {band} substitution should do the trick.

            Show
            gpdf Gregory Dubois-Felsmann added a comment - - edited em_min / em_max : it's not "vital", to be sure, but it seems reasonable to be consistent with the em_min / em_max we're reporting in the ObsCore table for the input images. prov_progenitor : yes, multiple instances is clearly what the standard envisions: Some keywords may be repeated to specify multiple values like provenance (suggested by (*) in the following table). Keyword Req or Should Description - Format - Example prov_progenitor (*) S Provenance of the original data - Format: free text However, if this is architecturally difficult, because your whole code is based on a dict, say, I'm OK if you concatenate them all, perhaps with semicolons, for now. A template with {band} substitution should do the trick.
            Hide
            erykoff Eli Rykoff added a comment -

            Not hard at all, there's no dict. I'll just change the config to a ListField. Just wanted to make sure I understood completely.

            Show
            erykoff Eli Rykoff added a comment - Not hard at all, there's no dict. I'll just change the config to a ListField . Just wanted to make sure I understood completely.
            erykoff Eli Rykoff made changes -
            Attachment dp02_properties_i.txt [ 60515 ]
            Attachment dp02_properties_gri.txt [ 60516 ]
            Hide
            erykoff Eli Rykoff added a comment -

            Okay, here are my proposed property files that go with your suggestions. I'm attaching one for i-band, one for the gri color. The other bands look a lot like i-band with suitable substitutions/wavelengths.

            Note that the hipsgen linter complains that temp:// is not a valid identifier, but Aladin.jar doesn't complain.

            dp02_properties_i.txt dp02_properties_gri.txt

            Show
            erykoff Eli Rykoff added a comment - Okay, here are my proposed property files that go with your suggestions. I'm attaching one for i-band, one for the gri color. The other bands look a lot like i-band with suitable substitutions/wavelengths. Note that the hipsgen linter complains that temp:// is not a valid identifier, but Aladin.jar doesn't complain. dp02_properties_i.txt dp02_properties_gri.txt
            erykoff Eli Rykoff made changes -
            Attachment dp02_properties_i_v2.txt [ 60530 ]
            Attachment dp02_properties_gri_v2.txt [ 60531 ]
            Hide
            erykoff Eli Rykoff added a comment -

            After feedback, here are updates to the properties files. MOC fraction is just for ci_imsim, that will be filled in properly on the real run. dp02_properties_i_v2.txt dp02_properties_gri_v2.txt

            Show
            erykoff Eli Rykoff added a comment - After feedback, here are updates to the properties files. MOC fraction is just for ci_imsim, that will be filled in properly on the real run. dp02_properties_i_v2.txt dp02_properties_gri_v2.txt
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            These look good to me; I think we can close this ticket now?

            Show
            gpdf Gregory Dubois-Felsmann added a comment - These look good to me; I think we can close this ticket now?
            Hide
            erykoff Eli Rykoff added a comment -

            We have converged!

            Show
            erykoff Eli Rykoff added a comment - We have converged!
            erykoff Eli Rykoff made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            erykoff Eli Rykoff made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              gpdf Gregory Dubois-Felsmann
              Reporter:
              gpdf Gregory Dubois-Felsmann
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Gregory Dubois-Felsmann, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.