Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34792

Deprecate version 0 refcat code

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      AP F22-2 (July)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Following RFC-851, deprecate the code that supports version 0 refcats (i.e., those without nJy flux units for their flux fields), for removal post-v25.

      We'll want to preserve a note somewhere (in getFormatVersionFromRefCat?) for post-removal that prints a "This is a version-0 refcat and is unsupported." (and note that that note should stay post-removal).

        Attachments

          Issue Links

            Activity

            Hide
            erykoff Eli Rykoff added a comment -

            I assume this includes updating the refcats in meas_astrom and pipe_tasks (at least) that are used for unit tests?

            Show
            erykoff Eli Rykoff added a comment - I assume this includes updating the refcats in meas_astrom and pipe_tasks (at least) that are used for unit tests?
            Hide
            Parejkoj John Parejko added a comment -

            Good point, Eli Rykoff: I'll make sure and do that. There's a script to do that already.

            Show
            Parejkoj John Parejko added a comment - Good point, Eli Rykoff : I'll make sure and do that. There's a script to do that already.
            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36887/pipeline
            Hide
            Parejkoj John Parejko added a comment - - edited

            @eli: do you mind doing this small review? It adds some deprecation warnings and notes about things to remove on the removal ticket, and also converts the v0 sdss refcats in two packages to v1. It looks like fgcmcal has some refcats in it: do those need to be converted?

            Here's the PRs:

            Show
            Parejkoj John Parejko added a comment - - edited @eli: do you mind doing this small review? It adds some deprecation warnings and notes about things to remove on the removal ticket, and also converts the v0 sdss refcats in two packages to v1. It looks like fgcmcal has some refcats in it: do those need to be converted? Here's the PRs: https://github.com/lsst/meas_algorithms/pull/285 https://github.com/lsst/meas_astrom/pull/167 https://github.com/lsst/pipe_tasks/pull/697
            Hide
            erykoff Eli Rykoff added a comment -

            Small comment on the deprecation message. Thanks for doing this conversion!

            Show
            erykoff Eli Rykoff added a comment - Small comment on the deprecation message. Thanks for doing this conversion!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Ian Sullivan, John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.