Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34793

Remove version 0 refcat code

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F23-1 (June)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Post v24, remove the deprecated version 0 refcat code, keeping around an error message/exception if such a refcat is encountered inside loadReferenceObjects.py (possibly just raise in getFormatVersionFromRefCat?).

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-36466 Do Release 26.0.0 of Science Pipelines

          • In Progress
          has to be finished together with

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-38991 Update ap_verify refcats

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-26300 Fix warnings in pipelines_check processing

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19580 refcats in ci_hsc are still version 0

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34792 Deprecate version 0 refcat code

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-851 Remove support for version 0 reference catalogs

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35671 Remove gen2 support from meas_algorithms

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-40113 Update PS1 catalogs on tiger from v0 to v1

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-575 Convert old refcats to nJy for RFC-549

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            While doing this, I also took care of some vestigial gen2 code.

            Show
            Parejkoj John Parejko added a comment - While doing this, I also took care of some vestigial gen2 code.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/39096/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/39096/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            PRs:

            Show
            Parejkoj John Parejko added a comment - PRs: https://github.com/lsst/meas_algorithms/pull/341 https://github.com/lsst/analysis_drp/pull/68 https://github.com/lsst/atmospec/pull/32 https://github.com/lsst/meas_astrom/pull/182 https://github.com/lsst/pipe_tasks/pull/808 https://github.com/lsst/jointcal/pull/247 https://github.com/lsst/ap_verify/pull/191
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jim Bosch: this is the bigger removal ticket; meas_algorithms is where the removal happened, and the other tickets are cleanups that hadn't happened earlier. Commits should all be fully atomic, as I took care of several other non-ticketed deprecation/gen2 removal here as well.

            Show
            Parejkoj John Parejko added a comment - Jim Bosch : this is the bigger removal ticket; meas_algorithms is where the removal happened, and the other tickets are cleanups that hadn't happened earlier. Commits should all be fully atomic, as I took care of several other non-ticketed deprecation/gen2 removal here as well.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good!  Very glad to see the Gen2 refcat-loader entry points gone.

            Show
            jbosch Jim Bosch added a comment - Looks good!  Very glad to see the Gen2 refcat-loader entry points gone.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Jim Bosch
              Watchers:
              Ian Sullivan, Jim Bosch, John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.