Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34801

Replace Diff_warpedExp with Diff_templateExp in diaPipe

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_association
    • Labels:
      None

      Description

      DiaPipelineTask uses *Diff_warpedExp for the butler name of the template that is passed to the alertPackager to make the cutouts. The new image difference tasks only output the *Diff_templateExp datasets, which have the correct bbox applied.

      This should be a non-breaking change: the old ImageDifferenceTask produces both the warpedExp and templateExp, and for making cutouts they should be substitutable for each other.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34786 Run ci_hits with the new image differencing

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34787 Run ci_cosmos and ci_hits with the new image differencing

          • Invalid
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33001 Design refactoring of ImageDifferenceTask

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35172 Run the diffim sprint dataset through the refactored imageDifference code

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33911 Test the performance of refactored image differencing

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins run to see if this works with the stack as-is: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36812/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins run to see if this works with the stack as-is: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36812/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Krzysztof Findeisen: Would you mind reviewing these three PRs? This cleans up our naming to consistently call the template "template", instead of some variation on "warp", in both the connections and dataset type names.

            In case Jira doesn't pick them up:

            Show
            Parejkoj John Parejko added a comment - Krzysztof Findeisen : Would you mind reviewing these three PRs? This cleans up our naming to consistently call the template "template", instead of some variation on "warp", in both the connections and dataset type names. In case Jira doesn't pick them up: https://github.com/lsst/ap_association/pull/153 https://github.com/lsst/ap_pipe/pull/115 https://github.com/lsst/ap_verify/pull/162
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Post review Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36874/pipeline

            I also ran ApVerify.yaml and ApVerifyWithFakes.yaml, and both ran successfully and compared similarly with their respective pipelines on main on ci_hits2015.

            Show
            Parejkoj John Parejko added a comment - - edited Post review Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36874/pipeline I also ran ApVerify.yaml and ApVerifyWithFakes.yaml, and both ran successfully and compared similarly with their respective pipelines on main on ci_hits2015.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Ian Sullivan, John Parejko, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.