Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3483

Calibration transformation should not fail on negative flux

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None

      Description

      Before database ingest, measured source fluxes are converted to magnitudes as per DM-2305. The default behaviour of afw::image::Calib is to throw when a negative flux is encountered, which derails the whole transformation procedure. Better is to return a NaN.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Jim Bosch – do you have time for a small review? This fixes a problem we ran into at yesterday's KPM/end-to-end session. All changes in tickets/DM-3483 on meas_base.

            Show
            swinbank John Swinbank added a comment - Jim Bosch – do you have time for a small review? This fixes a problem we ran into at yesterday's KPM/end-to-end session. All changes in tickets/DM-3483 on meas_base .
            Hide
            jbosch Jim Bosch added a comment -

            Everything looks fine. Only comments are on some preexisting nearby code, which are trivial enough that you're welcome to ignore them.

            Show
            jbosch Jim Bosch added a comment - Everything looks fine. Only comments are on some preexisting nearby code, which are trivial enough that you're welcome to ignore them.
            Hide
            swinbank John Swinbank added a comment -

            Thanks for the review!

            I agree with your comment about using != to check for loop termination, so I changed that as you suggested. I decided not to switch to auto for the iterator types, though, as I'm not aware of a way to force that to derive a const iterator until DM-2009 lands.

            Show
            swinbank John Swinbank added a comment - Thanks for the review! I agree with your comment about using != to check for loop termination, so I changed that as you suggested. I decided not to switch to auto for the iterator types, though, as I'm not aware of a way to force that to derive a const iterator until DM-2009 lands.

              People

              • Assignee:
                swinbank John Swinbank
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel