Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34834

IsolatedStarAssociationTask crashes if secondary band in tract has no overlap with primary band

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      Running the full IsolatedStarAssociationTask on RC2 DM-34794 led to a crash on one of the tracts at the very edge. Fortunately, this is not vital for the processing (since there was only 1 lonely isolated star in this tract). However, this did expose a bug in that https://github.com/lsst/pipe_tasks/blob/ba22ec62b9b9a2392aaa5a9a3d8dbfd25604c63d/python/lsst/pipe/tasks/isolatedStarAssociation.py#L428 does not check that there were any successful matches between the secondary and primary bands before trying to remove the matches.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          PR is here: https://github.com/lsst/pipe_tasks/pull/681
          Jenkins is here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36598/pipeline

          Show
          erykoff Eli Rykoff added a comment - PR is here: https://github.com/lsst/pipe_tasks/pull/681 Jenkins is here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36598/pipeline
          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          Thanks for the quick fix!

          Show
          lauren Lauren MacArthur added a comment - Thanks for the quick fix!
          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          Hhhmmm...should that Jenkins have had ci_hsc to that the task actually gets run?

          Show
          lauren Lauren MacArthur added a comment - Hhhmmm...should that Jenkins have had ci_hsc to that the task actually gets run?
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          The relevant test that exercises the code is in pipe_tasks, so I think it's fine.

          Show
          erykoff Eli Rykoff added a comment - The relevant test that exercises the code is in pipe_tasks , so I think it's fine.

            People

            Assignee:
            erykoff Eli Rykoff
            Reporter:
            erykoff Eli Rykoff
            Reviewers:
            Lauren MacArthur
            Watchers:
            Eli Rykoff, Lauren MacArthur
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.