Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3483

Calibration transformation should not fail on negative flux

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None

      Description

      Before database ingest, measured source fluxes are converted to magnitudes as per DM-2305. The default behaviour of afw::image::Calib is to throw when a negative flux is encountered, which derails the whole transformation procedure. Better is to return a NaN.

        Attachments

          Issue Links

            Activity

            No builds found.
            swinbank John Swinbank created issue -
            swinbank John Swinbank made changes -
            Field Original Value New Value
            Epic Link DM-1912 [ 15945 ]
            Hide
            swinbank John Swinbank added a comment -

            Jim Bosch – do you have time for a small review? This fixes a problem we ran into at yesterday's KPM/end-to-end session. All changes in tickets/DM-3483 on meas_base.

            Show
            swinbank John Swinbank added a comment - Jim Bosch – do you have time for a small review? This fixes a problem we ran into at yesterday's KPM/end-to-end session. All changes in tickets/DM-3483 on meas_base .
            swinbank John Swinbank made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-3489 [ DM-3489 ]
            Hide
            jbosch Jim Bosch added a comment -

            Everything looks fine. Only comments are on some preexisting nearby code, which are trivial enough that you're welcome to ignore them.

            Show
            jbosch Jim Bosch added a comment - Everything looks fine. Only comments are on some preexisting nearby code, which are trivial enough that you're welcome to ignore them.
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            swinbank John Swinbank added a comment -

            Thanks for the review!

            I agree with your comment about using != to check for loop termination, so I changed that as you suggested. I decided not to switch to auto for the iterator types, though, as I'm not aware of a way to force that to derive a const iterator until DM-2009 lands.

            Show
            swinbank John Swinbank added a comment - Thanks for the review! I agree with your comment about using != to check for loop termination, so I changed that as you suggested. I decided not to switch to auto for the iterator types, though, as I'm not aware of a way to force that to derive a const iterator until DM-2009 lands.
            swinbank John Swinbank made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.