Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34623 AP Performance sprint
  3. DM-34881

Create stack with timer decorators removed

    XMLWordPrintable

    Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: lsst_distrib
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      AP S22-6 (May)
    • Team:
      Alert Production

      Description

      To help make profiling call graphs easier to interpret, I'm going to pull down a fresh lsstsw, automate creating a branch for this ticket, remove all of the timing decorators, push the branch, build lsstsw with that branch, and run our tests on that lsstsw (on lsst-devl).

      I do not plan to ever merge this ticket, so no PRs will be created. Maybe to make that clear, I should name the branch u/parejkoj/TICKET-nomerge or something like that?

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34978 Allow disabling the timing decorator

          • To Do
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-39491 Run ap_verify on DC2 with profiling before rubinenv 7

          • Done

          Technical task - Created by JIRA Agile - do not edit or delete. Issue type for a technical task. DM-34948 Compare timing profiles with PCA, PSFex, and PIFF

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            I agree that using a user branch may minimize heartburn...

            Show
            ebellm Eric Bellm added a comment - I agree that using a user branch may minimize heartburn...
            Hide
            Permalink
            tjenness Tim Jenness added a comment - - edited

            I'm not sure what you mean by automating branch creation but that sounds more complicated than turning the timeMethod decorator into a no-op that returns the thing it's decorating.

            https://github.com/lsst/utils/blob/main/python/lsst/utils/timer.py

            Show
            tjenness Tim Jenness added a comment - - edited I'm not sure what you mean by automating branch creation but that sounds more complicated than turning the timeMethod decorator into a no-op that returns the thing it's decorating. https://github.com/lsst/utils/blob/main/python/lsst/utils/timer.py
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you Tim, that did the trick. I have u/parejkoj/DM-34881-nomerge as a branch with the timer disabled in this way, and it makes the profile call graph usable again.

            Show
            Parejkoj John Parejko added a comment - Thank you Tim, that did the trick. I have u/parejkoj/ DM-34881 -nomerge as a branch with the timer disabled in this way, and it makes the profile call graph usable again.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I would not be against adding the ability to set an environment variable to disable the decorator.

            Show
            tjenness Tim Jenness added a comment - I would not be against adding the ability to set an environment variable to disable the decorator.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            u/parejkoj/DM-34881-nomerge does the job for me, so I'm closing this ticket. DM-34978 is the followup to add an envvar to disable the decorator on a per-run basis.

            Show
            Parejkoj John Parejko added a comment - u/parejkoj/ DM-34881 -nomerge does the job for me, so I'm closing this ticket. DM-34978 is the followup to add an envvar to disable the decorator on a per-run basis.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Eric Bellm, John Parejko, Meredith Rawls, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.