Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34623 AP Performance sprint
  3. DM-34881

Create stack with timer decorators removed

    XMLWordPrintable

Details

    • Technical task
    • Status: Done
    • Resolution: Done
    • None
    • lsst_distrib
    • None
    • 1
    • AP S22-6 (May)
    • Alert Production

    Description

      To help make profiling call graphs easier to interpret, I'm going to pull down a fresh lsstsw, automate creating a branch for this ticket, remove all of the timing decorators, push the branch, build lsstsw with that branch, and run our tests on that lsstsw (on lsst-devl).

      I do not plan to ever merge this ticket, so no PRs will be created. Maybe to make that clear, I should name the branch u/parejkoj/TICKET-nomerge or something like that?

      Attachments

        Issue Links

          Activity

            ebellm Eric Bellm added a comment -

            I agree that using a user branch may minimize heartburn...

            ebellm Eric Bellm added a comment - I agree that using a user branch may minimize heartburn...
            tjenness Tim Jenness added a comment - - edited

            I'm not sure what you mean by automating branch creation but that sounds more complicated than turning the timeMethod decorator into a no-op that returns the thing it's decorating.

            https://github.com/lsst/utils/blob/main/python/lsst/utils/timer.py

            tjenness Tim Jenness added a comment - - edited I'm not sure what you mean by automating branch creation but that sounds more complicated than turning the timeMethod decorator into a no-op that returns the thing it's decorating. https://github.com/lsst/utils/blob/main/python/lsst/utils/timer.py
            Parejkoj John Parejko added a comment -

            Thank you Tim, that did the trick. I have u/parejkoj/DM-34881-nomerge as a branch with the timer disabled in this way, and it makes the profile call graph usable again.

            Parejkoj John Parejko added a comment - Thank you Tim, that did the trick. I have u/parejkoj/ DM-34881 -nomerge as a branch with the timer disabled in this way, and it makes the profile call graph usable again.
            tjenness Tim Jenness added a comment -

            I would not be against adding the ability to set an environment variable to disable the decorator.

            tjenness Tim Jenness added a comment - I would not be against adding the ability to set an environment variable to disable the decorator.

            u/parejkoj/DM-34881-nomerge does the job for me, so I'm closing this ticket. DM-34978 is the followup to add an envvar to disable the decorator on a per-run basis.

            Parejkoj John Parejko added a comment - u/parejkoj/ DM-34881 -nomerge does the job for me, so I'm closing this ticket. DM-34978 is the followup to add an envvar to disable the decorator on a per-run basis.

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Eric Bellm, John Parejko, Meredith Rawls, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.