Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34908

Consolidate task defaults and pipeline overrides

    XMLWordPrintable

    Details

    • Story Points:
      20
    • Epic Link:
    • Sprint:
      DRP S22B, Analysis Tools July 2022
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      There is a lot of duplication of config overriding in the pipeline definitions in analysis_drp. This is not only redundant, but prone to error (or just annoying to have to make multiple identical edits) if any of the canonical values need changing. This will get consolidated and cleaned up on this ticket.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35336 Several updates and fixes to stellar locus plots

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35386 Fix serialization of ConfigurableActionStructField when struct is empty

          • Done

            Activity

            Ascending order - Click to sort in descending order
            11 older comments
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Will do.

            Show
            lauren Lauren MacArthur added a comment - Will do.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            As per our (Sophie Reed, Jim Bosch, & myself) pair-coding session, I have reworked the PR leaving out a few of the more contentious commits (some may be discussed further in the context of the analysis_tools framework), and only included here those we all agreed on.

            Namely, I skipped:

            • changes to the colormap and sigma line formatting
            • removing the "_meas" from the plot names and definitions
            • redefining the flag selector naming

            I have rerun all of the HSC and LSSTCam-imSim pipelines.  There were no failures and all of the plots in my (fairly extensive) spot-checking look good.  

            They can be found in the following collections:

            /repo/main/u/lauren/DM-34908/coaddPlotsNew
            /repo/main/u/lauren/DM-34908/coaddPlotsNew/tiers
            /repo/main/u/lauren/DM-34908/visitPlotsNew
             
            /repo/dc2/u/lauren/DM-34908/coaddPlots
            /repo/dc2/u/lauren/DM-34908/visitPlots

             

            Jenkins with both ci's is running.

            Show
            lauren Lauren MacArthur added a comment - As per our ( Sophie Reed , Jim Bosch , & myself) pair-coding session, I have reworked the PR leaving out a few of the more contentious commits (some may be discussed further in the context of the analysis_tools framework), and only included here those we all agreed on. Namely, I skipped : changes to the colormap and sigma line formatting removing the "_meas" from the plot names and definitions redefining the flag selector naming I have rerun all of the HSC and LSSTCam-imSim pipelines.  There were no failures and all of the plots in my (fairly extensive) spot-checking look good.   They can be found in the following collections: /repo/main/u/lauren/ DM-34908 /coaddPlotsNew /repo/main/u/lauren/ DM-34908 /coaddPlotsNew/tiers /repo/main/u/lauren/ DM-34908 /visitPlotsNew   /repo/dc2/u/lauren/ DM-34908 /coaddPlots /repo/dc2/u/lauren/ DM-34908 /visitPlots   Jenkins with both ci's is running .
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Jenkins is green, so please go ahead with the final review, Sophie Reed.

            Show
            lauren Lauren MacArthur added a comment - Jenkins is green, so please go ahead with the final review, Sophie Reed .
            Hide
            Permalink
            sophiereed Sophie Reed added a comment -

            This looks fine now, thank you for the fixes.

            Show
            sophiereed Sophie Reed added a comment - This looks fine now, thank you for the fixes.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Thanks...merged and done.  I will now rework DM-35336 and get in back to you (in a form where you can more readily make the suggested edits you mentioned!)

            Show
            lauren Lauren MacArthur added a comment - Thanks...merged and done.  I will now rework DM-35336 and get in back to you (in a form where you can more readily make the suggested edits you mentioned!)

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Sophie Reed
              Watchers:
              Lauren MacArthur, Sophie Reed
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.