Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34919

Remove gen2 support from obs_lsst

    XMLWordPrintable

    Details

    • Story Points:
      3
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      The commissioning team have now fully transitioned to gen3 for LATISS and ComCam and DP0.2 demonstrated that imSim data has no problems with gen3. It is therefore time to remove gen2 support from obs_lsst.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35035 Remove gen2 support from obs_base

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35531 Remove remaining gen2 cruft from obs_lsst

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33523 Remove gen2 support from obs_cfht

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34856 Remove daf_persistence from obs_subaru

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I'm trying to see what is needed to switch the camera/butler/mapper tests in obs_base over to gen3 (by experimenting with obs_lsst). That should help with some of the 2->3 migration.

            cc/ John Parejko

            Show
            tjenness Tim Jenness added a comment - I'm trying to see what is needed to switch the camera/butler/mapper tests in obs_base over to gen3 (by experimenting with obs_lsst). That should help with some of the 2->3 migration. cc/ John Parejko
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            John Parejko would you like to look at this?

            I fixed all the obs_base gen2 butler tests to work for gen3 but now I'm not sure it was really worth the effort since it seems that obs_lsst is the only place that used them.

            It's likely that I could have deleted the tests without any change in test coverage but I wasn't really sure what they did until I started to look in detail. Mostly they are testing that day_obs/seq_num/name_in_raft/raft shorthand works for these instruments which we could probably move over to the generic ingest tests. The mapper tests are simply ignored. obs_lsst does not run any algorithmic tests.

            If you think I should delete the obs_base tests.py and test_latiss.py, test_imsim.py etc that's fine. I'm no longer convinced they do anything that the gen3 tests don't already test.

            Show
            tjenness Tim Jenness added a comment - John Parejko would you like to look at this? I fixed all the obs_base gen2 butler tests to work for gen3 but now I'm not sure it was really worth the effort since it seems that obs_lsst is the only place that used them. It's likely that I could have deleted the tests without any change in test coverage but I wasn't really sure what they did until I started to look in detail. Mostly they are testing that day_obs/seq_num/name_in_raft/raft shorthand works for these instruments which we could probably move over to the generic ingest tests. The mapper tests are simply ignored. obs_lsst does not run any algorithmic tests. If you think I should delete the obs_base tests.py and test_latiss.py, test_imsim.py etc that's fine. I'm no longer convinced they do anything that the gen3 tests don't already test.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I've reviewed the daf_butler PR.

            Show
            jbosch Jim Bosch added a comment - I've reviewed the daf_butler PR.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Jenkins passed (lsst_distrib, lsst_ci + ci_imsim).

            Show
            tjenness Tim Jenness added a comment - Jenkins passed (lsst_distrib, lsst_ci + ci_imsim).
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the cleanups and replies. We can assess just how much of this test infrastructure we can remove when we fully remove gen2.

            Show
            Parejkoj John Parejko added a comment - Thanks for the cleanups and replies. We can assess just how much of this test infrastructure we can remove when we fully remove gen2.
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            backport request is for the single astropy5.1 commit on daf_butler. 

            Show
            yusra Yusra AlSayyad added a comment - backport request is for the single astropy5.1 commit on daf_butler. 

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              John Parejko
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, Merlin Fisher-Levine, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.