I'm trying to see what is needed to switch the camera/butler/mapper tests in obs_base over to gen3 (by experimenting with obs_lsst). That should help with some of the 2->3 migration.

cc/ John Parejko

John Parejko would you like to look at this?

I fixed all the obs_base gen2 butler tests to work for gen3 but now I'm not sure it was really worth the effort since it seems that obs_lsst is the only place that used them.

It's likely that I could have deleted the tests without any change in test coverage but I wasn't really sure what they did until I started to look in detail. Mostly they are testing that day_obs/seq_num/name_in_raft/raft shorthand works for these instruments which we could probably move over to the generic ingest tests. The mapper tests are simply ignored. obs_lsst does not run any algorithmic tests.

If you think I should delete the obs_base tests.py and test_latiss.py, test_imsim.py etc that's fine. I'm no longer convinced they do anything that the gen3 tests don't already test.

I've reviewed the daf_butler PR.

Thanks for the cleanups and replies. We can assess just how much of this test infrastructure we can remove when we fully remove gen2.

backport request is for the single astropy5.1 commit on daf_butler.