Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3493

Fix crosstalk following ds9 interface changes

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None

      Description

      crosstalk.py in obs_subaru uses ds9 without actually displaying anything, which causes trouble if display_ds9 is not setup.

        Attachments

          Activity

          Hide
          price Paul Price added a comment - - edited

          Robert Lupton, could you please confirm I made this conversion in the manner intended by the interface?

          I also put the temporary mask plane removal into a finally clause, just in case (because we've been bitten by something like this before).

          price@price-laptop:~/LSST/obs/subaru (tickets/DM-3493=) $ git sub
          commit 34a6ca3dd35cb1b19cecd7db56efa2e817972441
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed Aug 19 00:59:13 2015 -0400
           
              crosstalk: convert to use new display interface
              
              Use of lsst.afw.display.ds9 now fails if new package display_ds9
              is not setup.  Converted to use the new interface.  The
              "setMaskVisibility" function doesn't appear to have a successor,
              so its use has been removed.
           
           python/lsst/obs/subaru/crosstalk.py | 19 +++++++++----------
           1 file changed, 9 insertions(+), 10 deletions(-)
           
          commit 677d4f73d1548ff7585d90ad6d6f7f3694c2279a
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed Aug 19 01:02:15 2015 -0400
           
              crosstalk: move mask plane add/remove into try/finally
              
              To ensure the temporary mask plane is removed, put the removal
              in the 'finally' clause.
           
           python/lsst/obs/subaru/crosstalk.py | 79 +++++++++++++++++++------------------
           1 file changed, 41 insertions(+), 38 deletions(-)
          

          Show
          price Paul Price added a comment - - edited Robert Lupton , could you please confirm I made this conversion in the manner intended by the interface? I also put the temporary mask plane removal into a finally clause, just in case (because we've been bitten by something like this before). price@price-laptop:~/LSST/obs/subaru (tickets/DM-3493=) $ git sub commit 34a6ca3dd35cb1b19cecd7db56efa2e817972441 Author: Paul Price <price@astro.princeton.edu> Date: Wed Aug 19 00:59:13 2015 -0400   crosstalk: convert to use new display interface Use of lsst.afw.display.ds9 now fails if new package display_ds9 is not setup. Converted to use the new interface. The "setMaskVisibility" function doesn't appear to have a successor, so its use has been removed.   python/lsst/obs/subaru/crosstalk.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)   commit 677d4f73d1548ff7585d90ad6d6f7f3694c2279a Author: Paul Price <price@astro.princeton.edu> Date: Wed Aug 19 01:02:15 2015 -0400   crosstalk: move mask plane add/remove into try/finally To ensure the temporary mask plane is removed, put the removal in the 'finally' clause.   python/lsst/obs/subaru/crosstalk.py | 79 +++++++++++++++++++------------------ 1 file changed, 41 insertions(+), 38 deletions(-)
          Hide
          price Paul Price added a comment -

          Looks like Robert Lupton is busy. John Swinbank, would you mind having a look please?

          Show
          price Paul Price added a comment - Looks like Robert Lupton is busy. John Swinbank , would you mind having a look please?
          Hide
          swinbank John Swinbank added a comment -

          Will do, but won't get to it immediately. Will have it done before the end of the cycle, I promise!

          Show
          swinbank John Swinbank added a comment - Will do, but won't get to it immediately. Will have it done before the end of the cycle, I promise!
          Hide
          swinbank John Swinbank added a comment -

          Looks basically fine. Minor comments in the PR; feel free to go ahead and merge after you've considered them.

          Show
          swinbank John Swinbank added a comment - Looks basically fine. Minor comments in the PR ; feel free to go ahead and merge after you've considered them.
          Hide
          price Paul Price added a comment -

          Thanks John Swinbank. Fixed up the frame numbers and made ds9 optional as requested. Your other comment was that a big reorganisation should be a separate commit, which it was already.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks John Swinbank . Fixed up the frame numbers and made ds9 optional as requested. Your other comment was that a big reorganisation should be a separate commit, which it was already. Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Paul Price, Robert Lupton
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel