Paul Price added a comment - 18/Aug/15 10:07 PM - edited Robert Lupton , could you please confirm I made this conversion in the manner intended by the interface? I also put the temporary mask plane removal into a finally clause, just in case (because we've been bitten by something like this before). price@price-laptop:~/LSST/obs/subaru (tickets/DM-3493=) $ git sub commit 34a6ca3dd35cb1b19cecd7db56efa2e817972441 Author: Paul Price <price@astro.princeton.edu> Date: Wed Aug 19 00:59:13 2015 -0400   crosstalk: convert to use new display interface Use of lsst.afw.display.ds9 now fails if new package display_ds9 is not setup. Converted to use the new interface. The "setMaskVisibility" function doesn't appear to have a successor, so its use has been removed.   python/lsst/obs/subaru/crosstalk.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)   commit 677d4f73d1548ff7585d90ad6d6f7f3694c2279a Author: Paul Price <price@astro.princeton.edu> Date: Wed Aug 19 01:02:15 2015 -0400   crosstalk: move mask plane add/remove into try/finally To ensure the temporary mask plane is removed, put the removal in the 'finally' clause.   python/lsst/obs/subaru/crosstalk.py | 79 +++++++++++++++++++------------------ 1 file changed, 41 insertions(+), 38 deletions(-)

Paul Price added a comment - 28/Aug/15 11:26 AM Looks like Robert Lupton is busy. John Swinbank , would you mind having a look please?

John Swinbank added a comment - 28/Aug/15 1:27 PM Will do, but won't get to it immediately. Will have it done before the end of the cycle, I promise!

John Swinbank added a comment - 30/Aug/15 9:28 AM Looks basically fine. Minor comments in the PR ; feel free to go ahead and merge after you've considered them.

Paul Price added a comment - 31/Aug/15 2:31 PM Thanks John Swinbank . Fixed up the frame numbers and made ds9 optional as requested. Your other comment was that a big reorganisation should be a separate commit, which it was already. Merged to master.