Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3511

Adopt Webserv to work with reworked db module

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ImgServ, metaserv, webserv
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          Hide
          jbecla Jacek Becla added a comment -

          Andy Salnikov: qserv/admin/bin/watcher.py has some code that relies on db. Since you will be redoing the watcher completely next month, I think there is no point in going through migrating this (unused) code right now. So, I am planning to leave it for you to handle through DM-3192. Sounds ok?

          Show
          jbecla Jacek Becla added a comment - Andy Salnikov : qserv/admin/bin/watcher.py has some code that relies on db. Since you will be redoing the watcher completely next month, I think there is no point in going through migrating this (unused) code right now. So, I am planning to leave it for you to handle through DM-3192 . Sounds ok?
          Hide
          salnikov Andy Salnikov added a comment -

          Yes, watcher will need a lot more work, makes sense to do everything at once, and it's not really used currently.

          Show
          salnikov Andy Salnikov added a comment - Yes, watcher will need a lot more work, makes sense to do everything at once, and it's not really used currently.
          Hide
          jbecla Jacek Becla added a comment -

          Andy, Brian, John, I migrated dax_imgserv (still working on webserv/dbserv/metaserv). You might want to start reviewing the https://github.com/lsst/dax_imgserv/pull/9, I suspect all 3 of you will want to peek. Thanks.

          Show
          jbecla Jacek Becla added a comment - Andy, Brian, John, I migrated dax_imgserv (still working on webserv/dbserv/metaserv). You might want to start reviewing the https://github.com/lsst/dax_imgserv/pull/9 , I suspect all 3 of you will want to peek. Thanks.
          Hide
          jbecla Jacek Becla added a comment -

          Ok, I think I am done, as far as I can tell I migrated everything. I tried to redo the full bremerton setup using sqlalchemy based version, and it (almost) works. There is one issue where Qserv chokes on queries generated by sqlalchemy, this will be addressed separately through DM-3929. It is hard to test everything without unit tests (but these are coming soon, so if I happened to miss anything hopefully we will uncover shortly through unit tests). Note there are 3 pull requests (you saw some of them earlier). I'm hoping we can close this issue along with DM-2299 and DM-2558 and DM-2322 tomorrow. Thanks.

          Show
          jbecla Jacek Becla added a comment - Ok, I think I am done, as far as I can tell I migrated everything. I tried to redo the full bremerton setup using sqlalchemy based version, and it (almost) works. There is one issue where Qserv chokes on queries generated by sqlalchemy, this will be addressed separately through DM-3929 . It is hard to test everything without unit tests (but these are coming soon, so if I happened to miss anything hopefully we will uncover shortly through unit tests). Note there are 3 pull requests (you saw some of them earlier). I'm hoping we can close this issue along with DM-2299 and DM-2558 and DM-2322 tomorrow. Thanks.
          Hide
          bvan Brian Van Klaveren added a comment -

          Looks fine. On a related note, I couldn't tell for sure, but is there a branch we never merged which fixed the lsst.dax.* imports?

          Show
          bvan Brian Van Klaveren added a comment - Looks fine. On a related note, I couldn't tell for sure, but is there a branch we never merged which fixed the lsst.dax.* imports?
          Hide
          salnikov Andy Salnikov added a comment -

          Looks OK too, few minor comments in PR. Brian says "fine", so I mark it as reviewed.

          Show
          salnikov Andy Salnikov added a comment - Looks OK too, few minor comments in PR. Brian says "fine", so I mark it as reviewed.

            People

            Assignee:
            fritzm Fritz Mueller
            Reporter:
            fritzm Fritz Mueller
            Reviewers:
            Andy Salnikov, Brian Van Klaveren
            Watchers:
            Andy Salnikov, Brian Van Klaveren, Jacek Becla, John Gates
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.