Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_diffim
-
Labels:None
-
Story Points:6
-
Sprint:Science Pipelines DM-W16-6, Alert Production X16 - 03, Alert Production X16 - 04
-
Team:Alert Production
Description
DipoleMeasurementTask currently runs dipole measurement plugins and runs its own implemented dipole classification method. This ticket translates dipole classification to a plugin itself to simplify DipoleMeasurementTask. Instead of inheriting from SingleFrameMeasurementTask, DipoleMeasurementTask will run SingleFrameMeasurementTask setting the appropriate default slots and plugins (including dipole classification plugin).
Attachments
Issue Links
- blocks
-
DM-3213 Get ImageDifferenceTask running again
- Done
Colin do you have time for a review (ip_diffim, pipe_tasks)?
Summary of changes:
DipoleMeasurementTask was just a default configuration + some documentation. There were two options for cleaning this up: make a very light DipoleMeasurementTask which inherited from pipe.base.Task consisting of a config and some documentation, or just delete it (and move the config + docs to ImageDifferenceTask. I chose deleting it, because I envision the processImageDifferenceTask as the reusable task to house the default configs for running SingleFrameMeasurement on image differences and the documentation on what those default plugins are and do. I see this ticket as an intermediate step and moving the config into the current ImageDifferenceTask as a step in the direction we wanted to go. I deleted the docs rather than moving them, because ImageDifferenceTask does not yet have a modern pipe task documentation.
Note: This changes the field name of the dipole classification from "dipole_classification" to "ip_diffim_ClassificationDipole_value" (and "ip_diffim_ClassificationDipole_flag") analogous to "base_ClassificationExtendedness_value"...