Details
-
Type:
Story
-
Status: Reviewed
-
Resolution: Unresolved
-
Fix Version/s: None
-
Component/s: sdm_schemas
-
Labels:
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
diaObject schema columns need descriptions and units in:
https://github.com/lsst/sdm_schemas/blob/main/yml/hsc.yaml
https://github.com/lsst/sdm_schemas/blob/main/yml/dp02_dc2.yaml
https://github.com/lsst/sdm_schemas/blob/main/yml/imsim.yaml
Needs backporting to v23.0.x imsim.yaml such that:
v23.0.x/imsim.yaml == main/dp02_dc2.yaml
They can be copied from the PPDB schema if available, the baseline schema https://github.com/lsst/sdm_schemas/blob/main/yml/baselineSchema.yaml if available, or inspected from the code
that creates it: https://github.com/lsst/pipe_tasks/blob/main/python/lsst/pipe/tasks/drpDiaCalculationPipe.py
Attachments
Issue Links
- relates to
-
- To Do
Activity
Hey John Parejko DP0.2 announcement going out today to current delegates. For today: any docstrings are better than no docstrings. I'm going to (1) make the two changes per the suggestions already made:
- write out Right Ascension and Declination
- switch back to the original order on dp02_dc2.yaml
(2) look for a reviewer who can read over the rest today, if you don't have time.
Still open to changing them per suggestions you have later.
Colin Slater/Fritz Mueller went over the freshly rebased PR live and hit the approved button on the PR. Would one of you his the Review Complete button here too.
All good.
Colin Slater
added a comment - All good. I just went through and put in comments on the descriptions (I only looked at the dc2 yaml file, but I assume the imsim one is just copy/pasted), but it's already been merged. I'll leave you to sort that out.
Jemkins passed: https://ci.lsst.codes/job/stack-os-matrix/36847/display/redirect
For posterity, our Slack convo with review details here: https://ci.lsst.codes/job/stack-os-matrix/36847/display/redirect