Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35186

Add FOCUSZ into ExposureInfo

    XMLWordPrintable

    Details

      Description

      FOCUSZ is not currently in ExposureInfo. We want to add this in so we can access it with the images along with the unit information. As I understand it this requires two steps:

      1) Add the focus_z information into ObservationInfo in astro_metadata_translator.

      2) Then it can be added to ExposureInfo.

      Questions I have:

      Should it go into VisitInfo? 

      How can you add distance units to values in the C++? I see you can use the lsst.geom units for angular things but not sure about linear distance.

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment -
          • You will have to add focus_z to the lsstCam translators.
          • I imagine it should be added to VisitInfo as a simple float where you document the units of mm (or whatever).
          • You will need to edit the makeVisitInfo code in obs_base to also copy the focus_z over from the ObservationInfo
          Show
          tjenness Tim Jenness added a comment - You will have to add focus_z to the lsstCam translators. I imagine it should be added to VisitInfo as a simple float where you document the units of mm (or whatever). You will need to edit the makeVisitInfo code in obs_base to also copy the focus_z over from the ObservationInfo
          Hide
          jbkalmbach Bryce Kalmbach added a comment -

          Tim Jenness I'm adding focus_z to the lsstCam translators now. Right now there is `FOCUSZ` in the headers for LATISS. Will the headers for LsstCam and ComCam also have `FOCUSZ` or will they use something else? I'm wondering because none of the test headers in obs_lsst at the moment for LsstCam and ComCam have `FOCUSZ`.

          Show
          jbkalmbach Bryce Kalmbach added a comment - Tim Jenness  I'm adding focus_z to the lsstCam translators now. Right now there is `FOCUSZ` in the headers for LATISS. Will the headers for LsstCam and ComCam also have `FOCUSZ` or will they use something else? I'm wondering because none of the test headers in obs_lsst at the moment for LsstCam and ComCam have `FOCUSZ`.
          Hide
          tjenness Tim Jenness added a comment -

          Policy is that the same concept across each instrument will use the same header so if someone spells it FOCUS_Z in LsstCam we need to tell them not to do that. Assume it will be FOCUSZ but you are going to have to make it optional (C controller files won't have a value). All the test headers for non-LATISS are from lab testing – we probably should get a simulated on-sky ComCam header added.

          Show
          tjenness Tim Jenness added a comment - Policy is that the same concept across each instrument will use the same header so if someone spells it FOCUS_Z in LsstCam we need to tell them not to do that. Assume it will be FOCUSZ but you are going to have to make it optional (C controller files won't have a value). All the test headers for non-LATISS are from lab testing – we probably should get a simulated on-sky ComCam header added.
          Hide
          jbkalmbach Bryce Kalmbach added a comment -

          PR on obs_lsst for this is ready for review: https://github.com/lsst/obs_lsst/pull/408 

          Thanks!

          Show
          jbkalmbach Bryce Kalmbach added a comment - PR on obs_lsst for this is ready for review: https://github.com/lsst/obs_lsst/pull/408   Thanks!
          Hide
          tjenness Tim Jenness added a comment -

          Looks great. Thanks

          Show
          tjenness Tim Jenness added a comment - Looks great. Thanks
          Hide
          jbkalmbach Bryce Kalmbach added a comment -

          Requesting reviews on PRs in:

          afw: https://github.com/lsst/afw/pull/646

          obs_base: https://github.com/lsst/obs_base/pull/425 

          Also, please let me know if there's anywhere else I still need to make changes. Thanks!

          Show
          jbkalmbach Bryce Kalmbach added a comment - Requesting reviews on PRs in: afw: https://github.com/lsst/afw/pull/646 obs_base: https://github.com/lsst/obs_base/pull/425   Also, please let me know if there's anywhere else I still need to make changes. Thanks!
          Hide
          krzys Krzysztof Findeisen added a comment -

          Bryce Kalmbach, are you ok with me taking over the afw portion of the review?

          Show
          krzys Krzysztof Findeisen added a comment - Bryce Kalmbach , are you ok with me taking over the afw portion of the review?
          Hide
          jbkalmbach Bryce Kalmbach added a comment -

          Yeah, of course. Thanks for taking it on!

          Show
          jbkalmbach Bryce Kalmbach added a comment - Yeah, of course. Thanks for taking it on!
          Hide
          krzys Krzysztof Findeisen added a comment -

          No objections to the afw part.

          Show
          krzys Krzysztof Findeisen added a comment - No objections to the afw part.
          Hide
          tjenness Tim Jenness added a comment -

          obs_base changes seem fine.

          Show
          tjenness Tim Jenness added a comment - obs_base changes seem fine.

            People

            Assignee:
            jbkalmbach Bryce Kalmbach
            Reporter:
            jbkalmbach Bryce Kalmbach
            Reviewers:
            Tim Jenness
            Watchers:
            Bryce Kalmbach, Krzysztof Findeisen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.