Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3518

prune stale obs_subaru dependencies

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Story Points:
      4
    • Epic Link:
    • Sprint:
      Science Pipelines DM-W16-6
    • Team:
      Data Release Production

      Description

      obs_subaru has some Eups dependencies that should be removed:

      • meas_extensions_multiShapelet (removed from the LSST stack, content moved to meas_modelfit)
      • meas_multifit (renamed to meas_modelfit)
      • fitsthumb (need to cherry-pick code from HSC to replace it)
      • pyfits (investigate what we use it for; it might not be needed)
      • psycopg2 (I don't think we'll ever use this on the LSST side; we should add it back to the HSC side after we re-fork)

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4251 Please include obs_subaru in CI

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4817 Read and understand `ci_hsc` and plan relationship with `validate_drp`

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-4816 Please add a way to get a Filter's canonical name

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4733 lsst-build should support enabling Git LFS in an already-cloned repository

          • Won't Fix
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. DM-4818 Unable to install `psycog2` using `lsstsw

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5007 pyfits 3.4 upgrade broke obs_subaru build

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-4358 obs_subaru tests should skip within the tests if test data can not be located

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            7 older comments
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            I put some comments on the pull request. I still have to pull down the branch to confirm that it compiles, but I'll wait to hear your response to the comments (nothing major, but a few items would require re-checking).

            Show
            lauren Lauren MacArthur added a comment - I put some comments on the pull request. I still have to pull down the branch to confirm that it compiles, but I'll wait to hear your response to the comments (nothing major, but a few items would require re-checking).
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks for the comments – I've responded to them on the PR.

            Show
            swinbank John Swinbank added a comment - Thanks for the comments – I've responded to them on the PR.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Following discussion on the PR, I've added two tiny additional commits to this ticket:

            Could you please also consider them in the review?

            Show
            swinbank John Swinbank added a comment - Following discussion on the PR, I've added two tiny additional commits to this ticket: https://github.com/lsst/obs_subaru/commit/2067d129cf45eebd5555425d094f66f4202a64e1 https://github.com/lsst/obs_subaru/commit/5d5d421ee24f49149bc343201cf72189c40450a6 Could you please also consider them in the review?
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            All looks good. Feel free to merge to master (when the Jenkins integration is taken care of).

            Show
            lauren Lauren MacArthur added a comment - All looks good. Feel free to merge to master (when the Jenkins integration is taken care of).
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Added a further commit which addresses the pyfits API change per DM-5007. It makes sense to include that on this ticket since:

            • Without the fix, the new test cases here won't run;
            • The test cases here demonstrate that the fix actually works!
            Show
            swinbank John Swinbank added a comment - Added a further commit which addresses the pyfits API change per DM-5007 . It makes sense to include that on this ticket since: Without the fix, the new test cases here won't run; The test cases here demonstrate that the fix actually works!

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Lauren MacArthur
              Watchers:
              Jim Bosch, John Swinbank, Lauren MacArthur, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.