Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35199

Fix python package names

    XMLWordPrintable

    Details

    • Team:
      Architecture
    • Urgent?:
      No

      Description

      After publishing middle-ware packages to PyPi,
      git+https://github.com/lsst/ references need to be updated as PyPy required to change
      the package name

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            I'm a bit worried.

            Consider what happens if on a Thursday I make a change to utils that now breaks daf_butler and pipe_base. On the ticket branch I can make butler and pipe_base use the utils code from github as a dependency but if I merge it what do I do next? For the next few days ctrl_mpexec won't be able to depend on a daf_butler that needs the new utils unless it also changes back to the github URL. On the day of the weekly tag do we go through and change everything quickly to PyPI again? This does not seem workable.

            Do we pip install dev_requirements.txt in actions and have a different set to what goes in pypi? Is there some way to use the pyproject.toml to specify a set of developer dependencies?

            Show
            tjenness Tim Jenness added a comment - I'm a bit worried. Consider what happens if on a Thursday I make a change to utils that now breaks daf_butler and pipe_base. On the ticket branch I can make butler and pipe_base use the utils code from github as a dependency but if I merge it what do I do next? For the next few days ctrl_mpexec won't be able to depend on a daf_butler that needs the new utils unless it also changes back to the github URL. On the day of the weekly tag do we go through and change everything quickly to PyPI again? This does not seem workable. Do we pip install dev_requirements.txt in actions and have a different set to what goes in pypi? Is there some way to use the pyproject.toml to specify a set of developer dependencies?
            Show
            wittgen Matthias Wittgen added a comment - For now for the packages dealt with in this ticket it would be sufficient to fix the package names as the build workflows are currently broken git+ https://github.com/lsst/daf_butler@main#egg=lsst-daf-butler git+ https://github.com/lsst/utils@main#egg=lsst-utils git+ https://github.com/lsst/pipe_base@main#egg=lsst-pipe-base git+ https://github.com/lsst/resources@main#egg=lsst-resources git+ https://github.com/lsst/ctrl_mpexec@main#egg=lsst-ctrl-mpexec git+ https://github.com/lsst/ctrl_mpexec@main#egg=lsst-ctrl-mpexec
            Hide
            tjenness Tim Jenness added a comment -

            Okay. So the names are wrong because they don't use the `lsst-` prefix that we added? Presumably the pypi upload needs to list dependencies that are not git+https? Do you agree that the actions should always run with git+https though?

            Show
            tjenness Tim Jenness added a comment - Okay. So the names are wrong because they don't use the `lsst-` prefix that we added? Presumably the pypi upload needs to list dependencies that are not git+https? Do you agree that the actions should always run with git+https though?
            Hide
            wittgen Matthias Wittgen added a comment -

            Correct. The PyPi build cannot deal with git+https dependencies.
            I wanted to first fix what is broken and then go back to he PyPi published packages and try to implement a fix along what you proposed.

            Show
            wittgen Matthias Wittgen added a comment - Correct. The PyPi build cannot deal with git+https dependencies. I wanted to first fix what is broken and then go back to he PyPi published packages and try to implement a fix along what you proposed.
            Hide
            wittgen Matthias Wittgen added a comment - - edited

            Removed resources from this ticket.

            Show
            wittgen Matthias Wittgen added a comment - - edited Removed resources from this ticket.
            Hide
            tjenness Tim Jenness added a comment -

            Looks fine as a quick fix.

            Show
            tjenness Tim Jenness added a comment - Looks fine as a quick fix.
            Hide
            wittgen Matthias Wittgen added a comment -

            Yes. putting resources back

            Show
            wittgen Matthias Wittgen added a comment - Yes. putting resources back

              People

              Assignee:
              wittgen Matthias Wittgen
              Reporter:
              wittgen Matthias Wittgen
              Reviewers:
              Tim Jenness
              Watchers:
              Matthias Wittgen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.