Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35252

Add DECam config overrides into cpBias and cpFlat pipelines

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      At present, the $CP_PIPE_DIR/pipelines/DarkEnergyCamera/cpFlat.yaml pipeline does not contain any of the de-facto standard config overrides used for DECam data reductions:

      -c isr:overscan.fitType='MEDIAN_PER_ROW'
      		 
      -c cpFlatNorm:level='AMP'

      Furthermore, no such equivalent cpBias.yaml pipeline exists for DECam. This ticket creates the cpBias.yaml pipeline, and adds in the above config overrides where relevant.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-30651 Switch DECam overscan correction to median per row

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment - - edited

            Would you have a chance to look at this Chris? On closer inspection, it looks like the inclusion of the instrument identifier allows for any already-defined camera specific config overrides to be automatically picked up. This is not only cleaner-looking, but means that DECam-specific config overrides only need to be specified in one place in the future.

            PR for this ticket. Jenkins run for this ticket.

            Show
            lskelvin Lee Kelvin added a comment - - edited Would you have a chance to look at this Chris? On closer inspection, it looks like the inclusion of the instrument identifier allows for any already-defined camera specific config overrides to be automatically picked up. This is not only cleaner-looking, but means that DECam-specific config overrides only need to be specified in one place in the future. PR for this ticket . Jenkins run for this ticket .
            Hide
            Permalink
            czw Christopher Waters added a comment -

            Everything looks good.  I don't know if any other calibrations need converted pipelines, but they can always be added in the future if they are needed.

            Show
            czw Christopher Waters added a comment - Everything looks good.  I don't know if any other calibrations need converted pipelines, but they can always be added in the future if they are needed.
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Thanks Chris. So far, for all DECam reductions to-date, we've only made use of the cpBias and cpFlat CP pipelines. As you mention, if other CP pipelines are required in the future for DECam, we can add them as needed. With Jenkins completing successfully, the ticket branch has been merged and deleted. Cheers!

            Show
            lskelvin Lee Kelvin added a comment - Thanks Chris. So far, for all DECam reductions to-date, we've only made use of the cpBias and cpFlat CP pipelines. As you mention, if other CP pipelines are required in the future for DECam, we can add them as needed. With Jenkins completing successfully, the ticket branch has been merged and deleted. Cheers!

              People

              Assignee:
              lskelvin Lee Kelvin
              Reporter:
              lskelvin Lee Kelvin
              Reviewers:
              Christopher Waters
              Watchers:
              Christopher Waters, Lee Kelvin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.