Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35292

Remove MeasurementError in trailedSources

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      DM-35237 suggests we remove MeasurementError from measurement plugins that have access to a source record. This ticket is to do that in meas_extensions_trailedSources.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35237 Remove lsst.meas.base.MeasurementError

          • To Do
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35309 Improve efficiency of trailed source measurement

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Ian Sullivan would you mind doing this small review? I change the use of MeasurementError to follow the discussion in DM-35237 and fix the log usage.

            I did see that there are a lot of numpy math functions in here for scalar floats and in theory they are faster with math. There is also a calculation of the sqrt of PI for every call to measure, but looking at a profile there isn't much of a hotspot there even when called two hundred thousand times.

            Show
            tjenness Tim Jenness added a comment - Ian Sullivan would you mind doing this small review? I change the use of MeasurementError to follow the discussion in DM-35237 and fix the log usage. I did see that there are a lot of numpy math functions in here for scalar floats and in theory they are faster with math . There is also a calculation of the sqrt of PI for every call to measure, but looking at a profile there isn't much of a hotspot there even when called two hundred thousand times.
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            I've filed DM-35309 to do the efficiency improvements as a training exercise for one of our new developers.

            Show
            sullivan Ian Sullivan added a comment - I've filed DM-35309 to do the efficiency improvements as a training exercise for one of our new developers.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Ian Sullivan
              Watchers:
              Ian Sullivan, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.