Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35322

ForcedPhotCcdFromDataFrameTask needs local calib plugins

    XMLWordPrintable

Details

    • DM Science
    • No

    Description

      ForcedPhotCcdFromDataFrameTask overwrites the measurement plugins used by the parent class, which removes base_LocalPhotoCalib and base_LocalWcs. These tasks are necessary for calibration of the parquet files downstream of this task, and should be re-added.

      Attachments

        Activity

          ctslater Colin Slater added a comment -

          Added the two plugins plus base_LocalBackground. When I now run DRP.yaml#forcedPhotCcdOnDiaObjects,forcedPhotDiffOnDiaObjects,writeForcedSourceOnDiaObjectTable, I get all of the calib columns in mergedForcedSourceOnDiaObject.

           

          ctslater Colin Slater added a comment - Added the two plugins plus base_LocalBackground. When I now run DRP.yaml#forcedPhotCcdOnDiaObjects,forcedPhotDiffOnDiaObjects,writeForcedSourceOnDiaObjectTable, I get all of the calib columns in mergedForcedSourceOnDiaObject.  
          ctslater Colin Slater added a comment -

          Ready for review. I'm expecting that DM-35538 will make missing columns throw an exception in general, so I've kept this to just the fix itself and didn't add a test. Jenkins is running.

          ctslater Colin Slater added a comment - Ready for review. I'm expecting that DM-35538 will make missing columns throw an exception in general, so I've kept this to just the fix itself and didn't add a test. Jenkins is running .

          I'm still going to add something to ci_hsc and ci_imsim that check to see if all rows are NaN for any columns, but it doesn't have to be done on this ticket.

          yusra Yusra AlSayyad added a comment - I'm still going to add something to ci_hsc and ci_imsim that check to see if all rows are NaN for any columns, but it doesn't have to be done on this ticket.
          ctslater Colin Slater added a comment -

          ci_imsim rightfully complained the local calib flag columns are listed as doubles in sdm_schemas, instead of bools. Added commits to correct the schemas and started a new jenkins run.

          ctslater Colin Slater added a comment - ci_imsim rightfully complained the local calib flag columns are listed as doubles in sdm_schemas, instead of bools. Added commits to correct the schemas and started a new jenkins run .

          People

            ctslater Colin Slater
            ctslater Colin Slater
            Yusra AlSayyad
            Colin Slater, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.