Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base
-
Team:DM Science
-
Urgent?:No
Description
ForcedPhotCcdFromDataFrameTask overwrites the measurement plugins used by the parent class, which removes base_LocalPhotoCalib and base_LocalWcs. These tasks are necessary for calibration of the parquet files downstream of this task, and should be re-added.
Attachments
Activity
Colin Slater
created issue -
Colin Slater
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Colin Slater [ ctslater ] |
Colin Slater
made changes -
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
Colin Slater
made changes -
| Attachment | image-2022-07-15-13-59-57-442.png [ 62532 ] |
Colin Slater
added a comment - Ready for review. I'm expecting that DM-35538 will make missing columns throw an exception in general, so I've kept this to just the fix itself and didn't add a test. Jenkins is running . Colin Slater
made changes -
| Reviewers | Yusra AlSayyad [ yusra ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Colin Slater
made changes -
| Labels | backport-v23 |
I'm still going to add something to ci_hsc and ci_imsim that check to see if all rows are NaN for any columns, but it doesn't have to be done on this ticket.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
ci_imsim rightfully complained the local calib flag columns are listed as doubles in sdm_schemas, instead of bools. Added commits to correct the schemas and started a new jenkins run.
Colin Slater
added a comment - ci_imsim rightfully complained the local calib flag columns are listed as doubles in sdm_schemas, instead of bools. Added commits to correct the schemas and started a new jenkins run . Colin Slater
made changes -
| Labels | backport-v23 | backport-approved backport-done backport-v23 |
Colin Slater
made changes -
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| Team | Data Release Production [ 10301 ] | DM Science [ 12218 ] |
Added the two plugins plus base_LocalBackground. When I now run DRP.yaml#forcedPhotCcdOnDiaObjects,forcedPhotDiffOnDiaObjects,writeForcedSourceOnDiaObjectTable, I get all of the calib columns in mergedForcedSourceOnDiaObject.