Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ap_association
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:AP F22-2 (July)
-
Team:Alert Production
-
Urgent?:No
Description
While implementing DM-34539, I noticed that the code paths for config.doRemoveSkySources=True do not appear to be covered by any tests. I had to add another such path in the peak significance calculations, but I didn't add a test because I didn't want to get bogged down adding sky source infrastructure to the test suite (and because I don't fully understand how sky sources are managed). We should add some fake sky sources to TestTransformDiaSourceCatalogTask, and confirm that the code handles them the way we would expect it to with that config option both True and False.
Taking this on now, as Eric Bellm's fix of my bug in
DM-34539made me worried about the fragility of this code to how sky sources are handled and how the dataframe is populated.