Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35331

Add tests of sky source handling in transformDiaSourceCat

    XMLWordPrintable

Details

    • 2
    • AP F22-2 (July)
    • Alert Production
    • No

    Description

      While implementing DM-34539, I noticed that the code paths for config.doRemoveSkySources=True do not appear to be covered by any tests. I had to add another such path in the peak significance calculations, but I didn't add a test because I didn't want to get bogged down adding sky source infrastructure to the test suite (and because I don't fully understand how sky sources are managed). We should add some fake sky sources to TestTransformDiaSourceCatalogTask, and confirm that the code handles them the way we would expect it to with that config option both True and False.

      Attachments

        Issue Links

          Activity

            Parejkoj John Parejko added a comment -

            Taking this on now, as ebellm's fix of my bug in DM-34539 made me worried about the fragility of this code to how sky sources are handled and how the dataframe is populated.

            Parejkoj John Parejko added a comment - Taking this on now, as ebellm 's fix of my bug in DM-34539 made me worried about the fragility of this code to how sky sources are handled and how the dataframe is populated.
            Parejkoj John Parejko added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36982/pipeline
            Parejkoj John Parejko added a comment -

            krzys: mind taking this small-ish review? While working on it, I demonstrated that this would have caught the problem in my original version of this significance code (not dealing with sky sources correctly).

            https://github.com/lsst/ap_association/pull/155

            Parejkoj John Parejko added a comment - krzys : mind taking this small-ish review? While working on it, I demonstrated that this would have caught the problem in my original version of this significance code (not dealing with sky sources correctly). https://github.com/lsst/ap_association/pull/155

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Krzysztof Findeisen
              Eric Bellm, Ian Sullivan, John Parejko, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.