Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35331

Add tests of sky source handling in transformDiaSourceCat

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F22-2 (July)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      While implementing DM-34539, I noticed that the code paths for config.doRemoveSkySources=True do not appear to be covered by any tests. I had to add another such path in the peak significance calculations, but I didn't add a test because I didn't want to get bogged down adding sky source infrastructure to the test suite (and because I don't fully understand how sky sources are managed). We should add some fake sky sources to TestTransformDiaSourceCatalogTask, and confirm that the code handles them the way we would expect it to with that config option both True and False.

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35846 Investigate approaches for enforcing sdm_schema in the output of ap_association

          • To Do
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34539 Add detection significance to DIASources and apdb

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue relates to DM-34539 [ DM-34539 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-34931 [ 1598492 ]
            Labels ap-analysis
            Parejkoj John Parejko made changes -
            Assignee John Parejko [ parejkoj ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Taking this on now, as Eric Bellm's fix of my bug in DM-34539 made me worried about the fragility of this code to how sky sources are handled and how the dataframe is populated.

            Show
            Parejkoj John Parejko added a comment - Taking this on now, as Eric Bellm 's fix of my bug in DM-34539 made me worried about the fragility of this code to how sky sources are handled and how the dataframe is populated.
            Parejkoj John Parejko made changes -
            Sprint AP F22-2 (July) [ 1171 ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36982/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36982/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Krzysztof Findeisen: mind taking this small-ish review? While working on it, I demonstrated that this would have caught the problem in my original version of this significance code (not dealing with sky sources correctly).

            https://github.com/lsst/ap_association/pull/155

            Show
            Parejkoj John Parejko added a comment - Krzysztof Findeisen : mind taking this small-ish review? While working on it, I demonstrated that this would have caught the problem in my original version of this significance code (not dealing with sky sources correctly). https://github.com/lsst/ap_association/pull/155
            Parejkoj John Parejko made changes -
            Reviewers Krzysztof Findeisen [ krzys ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            krzys Krzysztof Findeisen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Parejkoj John Parejko made changes -
            Story Points 2
            sullivan Ian Sullivan made changes -
            Rank Ranked lower
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Parejkoj John Parejko made changes -
            Link This issue is triggering DM-35846 [ DM-35846 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Eric Bellm, Ian Sullivan, John Parejko, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.