Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35383

Configure ESS accelerometer monitoring of AuxTel

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      TSSW Sprint - Jul 04 - Jul 18
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Update the ESS configuration in ts_config_ocs to report data from the 3-axis accelerometer on the AuxTel.

      This exposed some issues with LabJackAccelerometerDataClient which I will fix on the same ticket, including:

      • We need offset and scale for each accelerometer channel.
      • We need to be able to read multiple accelerometers with one LabJack.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35384 Disable humidity sensors with air pressure on AT and MT

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Pull requests:

            Show
            rowen Russell Owen added a comment - Pull requests: https://github.com/lsst-ts/ts_config_ocs/pull/88 https://github.com/lsst-ts/ts_ess_labjack/pull/14
            Hide
            Permalink
            rowen Russell Owen added a comment -

            After discussion with the stakeholders and deciding that using the Welch was too elaborate for the ESS (the issue is supporting sufficient configuration and then picking suitable values). For now, at least, we have decided to go with plain FFT.

            This update supports an arbitrary number of accelerometers per data client and also writes the raw-ish acceleration data, after applying offset and scaling using the ESS accelerometer telemetry topic. If you feel strongly that the data should be truly raw (no offset or scale), then please do note that here and/or in the review. I do see that the XML description really says "raw"; I just feel uneasy ignoring the given calibrations (especially scale; offset can easily be determined from the raw data).

            I am asking Petr Kubanek to review the ts_ess_labjack PR and Craig Lage to review the new ESS configuration parameters in ts_config_ocs. Please feel free to comment on the other PR as well. Patrick Ingraham: feel free to weigh in as well.

            Show
            rowen Russell Owen added a comment - After discussion with the stakeholders and deciding that using the Welch was too elaborate for the ESS (the issue is supporting sufficient configuration and then picking suitable values). For now, at least, we have decided to go with plain FFT. This update supports an arbitrary number of accelerometers per data client and also writes the raw-ish acceleration data, after applying offset and scaling using the ESS accelerometer telemetry topic. If you feel strongly that the data should be truly raw (no offset or scale), then please do note that here and/or in the review. I do see that the XML description really says "raw"; I just feel uneasy ignoring the given calibrations (especially scale; offset can easily be determined from the raw data). I am asking Petr Kubanek to review the ts_ess_labjack PR and Craig Lage to review the new ESS configuration parameters in ts_config_ocs. Please feel free to comment on the other PR as well. Patrick Ingraham : feel free to weigh in as well.
            Hide
            Permalink
            pkubanek Petr Kubanek added a comment -

            Python code reviewed, and looks good.

            Show
            pkubanek Petr Kubanek added a comment - Python code reviewed, and looks good.
            Hide
            Permalink
            cslage Craig Lage added a comment -

            I made comments of minor errors in both PRs.

            Show
            cslage Craig Lage added a comment - I made comments of minor errors in both PRs.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            I updated both PRs based on the excellent suggestions from both reviewers.

            I also modified LabJackDataClient to use calibrated = (raw - offset) * scale, instead of applying offset after scaling. This will not affect existing users because the only LabJackDataClient configuration in ts_config_ocs has offset=0.

            Tagged ts_ess_labjack v0.6.0. Merged the ts_config_ocs update to develop but did not merge it to main and tag it yet – do that when we are ready to run it, and preferably only after testing it.

            Show
            rowen Russell Owen added a comment - I updated both PRs based on the excellent suggestions from both reviewers. I also modified LabJackDataClient to use calibrated = (raw - offset) * scale, instead of applying offset after scaling. This will not affect existing users because the only LabJackDataClient configuration in ts_config_ocs has offset=0. Tagged ts_ess_labjack v0.6.0. Merged the ts_config_ocs update to develop but did not merge it to main and tag it yet – do that when we are ready to run it, and preferably only after testing it.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Craig Lage, Petr Kubanek
              Watchers:
              Craig Lage, Patrick Ingraham, Petr Kubanek, Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.