Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_auxiliary_telescope
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:TSSW Sprint - Jul 04 - Jul 18
-
Team:Telescope and Site
-
Urgent?:No
Description
Update the ESS configuration in ts_config_ocs to report data from the 3-axis accelerometer on the AuxTel.
This exposed some issues with LabJackAccelerometerDataClient which I will fix on the same ticket, including:
- We need offset and scale for each accelerometer channel.
- We need to be able to read multiple accelerometers with one LabJack.
Attachments
Issue Links
- relates to
-
- Won't Fix
Activity
| Summary | Configure ESS vibration monitoring of AuxTel | Configure ESS accelerometer monitoring of AuxTel |
| Story Points | 1 | 3 |
| Story Points | 3 | 2 |
| Description | Update the ESS configuration in ts_config_ocs to report data from the 3-axis accelerometer on the AuxTel. |
Update the ESS configuration in ts_config_ocs to report data from the 3-axis accelerometer on the AuxTel.
This exposed some issues with LabJackAccelerometerDataClient which I will fix on the same ticket, including: * We need offset and scale for each accelerometer channel. * We need to be able to read multiple accelerometers with one LabJack. |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
After discussion with the stakeholders and deciding that using the Welch was too elaborate for the ESS (the issue is supporting sufficient configuration and then picking suitable values). For now, at least, we have decided to go with plain FFT.
This update supports an arbitrary number of accelerometers per data client and also writes the raw-ish acceleration data, after applying offset and scaling using the ESS accelerometer telemetry topic. If you feel strongly that the data should be truly raw (no offset or scale), then please do note that here and/or in the review. I do see that the XML description really says "raw"; I just feel uneasy ignoring the given calibrations (especially scale; offset can easily be determined from the raw data).
I am asking Petr Kubanek to review the ts_ess_labjack PR and Craig Lage to review the new ESS configuration parameters in ts_config_ocs. Please feel free to comment on the other PR as well. Patrick Ingraham: feel free to weigh in as well.
| Reviewers | Craig Lage, Petr Kubanek [ cslage, pkubanek ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Python code reviewed, and looks good.
Petr Kubanek
added a comment - Python code reviewed, and looks good. I made comments of minor errors in both PRs.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
I updated both PRs based on the excellent suggestions from both reviewers.
I also modified LabJackDataClient to use calibrated = (raw - offset) * scale, instead of applying offset after scaling. This will not affect existing users because the only LabJackDataClient configuration in ts_config_ocs has offset=0.
Tagged ts_ess_labjack v0.6.0. Merged the ts_config_ocs update to develop but did not merge it to main and tag it yet – do that when we are ready to run it, and preferably only after testing it.
| Story Points | 2 | 3 |
| Story Points | 3 | 4 |
Pull requests: