Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35426

Fix isolated star association task connection type for DECam

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: drp_pipe
    • Labels:
      None

      Description

      When the isolated star association task was added into the newly created step 2b subset in DM-34853, the input connection was not updated to reference the new 'preSourceTable_visit' inputs that are produced in step 2a (the 'pre' is missing by default). This ticket resolves that issue.

        Attachments

          Issue Links

            Activity

            Hide
            lskelvin Lee Kelvin added a comment -

            Thanks for looking at this Yusra AlSayyad, the PR is up on GH. I don't think Jenkins is required here, but happy to kick one off anyway if you think it would help.

            I've added a before and after pipeline graph for the Merian DECam step 2b to show that pipetask build correctly picks up the new config change. Graphs constructed using this command:

            pipetask build \
            -p $DRP_PIPE_DIR/pipelines/DECam/DRP-Merian.yaml#step2b \
            --pipeline-dot /tmp/pipeline.dot; \
            dot /tmp/pipeline.dot -Tpdf > $LOGDIR/pipeline_step2b.pdf
            

            Show
            lskelvin Lee Kelvin added a comment - Thanks for looking at this Yusra AlSayyad , the PR is up on GH . I don't think Jenkins is required here, but happy to kick one off anyway if you think it would help. I've added a before and after pipeline graph for the Merian DECam step 2b to show that pipetask build correctly picks up the new config change. Graphs constructed using this command: pipetask build \ -p $DRP_PIPE_DIR/pipelines/DECam/DRP-Merian.yaml#step2b \ --pipeline-dot /tmp/pipeline.dot; \ dot /tmp/pipeline.dot -Tpdf > $LOGDIR/pipeline_step2b.pdf
            Hide
            lskelvin Lee Kelvin added a comment -

            Thanks Yusra. Branch merged and deleted, cheers!

            Show
            lskelvin Lee Kelvin added a comment - Thanks Yusra. Branch merged and deleted, cheers!

              People

              Assignee:
              lskelvin Lee Kelvin
              Reporter:
              lskelvin Lee Kelvin
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Lee Kelvin, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.