Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3549

Further improve the TAN-SIP WCS fitter

    Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None
    • Templates:
    • Story Points:
      12
    • Epic Link:
    • Sprint:
      Science Pipelines DM-W16-6, DRP F16-2, DRP F16-3, DRP F16-4, DRP F16-5
    • Team:
      Data Release Production

      Description

      lsst.meas.astrom.sip.makeCreateWcsWithSip, our C++ implementation of a TAN-SIP WCS fitter, fits for X and then Y. Thus it must be called several times (e.g. by FitTanSipWcsTask) in order to converge. Please make makeCreateWcsWithSip fit for X and Y simultaneously. This would simplify its use and speed up fitting.

      In addition, please investigate whether outlier rejection can be added to makeCreateWcsWithSip. As of DM-3492 outlier rejection is implemented in FitTanSipWcsTask, but it would make makeCreateWcsWithSip easier to use and speed up fitting if makeCreateWcsWithSip did the outlier rejection itself. On the other hand, the current solution may be sufficient.

      Once the above is implemented, please simplify FitTanSipWcsTask by removing the unneeded extra iterations used to work around these problems.

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  jbosch Jim Bosch
                  Reporter:
                  rowen Russell Owen
                  Reviewers:
                  Russell Owen
                  Watchers:
                  Colin Slater, David Shupe, Dominique Boutigny, Fred Moolekamp, Jim Bosch, John Swinbank, Nicolas Chotard, Paul Price, Pierre Astier, Robert Lupton, Russell Owen, Simon Krughoff, Tim Jenness
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  13 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel