Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None
    • Templates:
    • Story Points:
      12
    • Epic Link:
    • Sprint:
      Science Pipelines DM-W16-6, DRP F16-2, DRP F16-3, DRP F16-4, DRP F16-5
    • Team:
      Data Release Production

      Description

      lsst.meas.astrom.sip.makeCreateWcsWithSip, our C++ implementation of a TAN-SIP WCS fitter, fits for X and then Y. Thus it must be called several times (e.g. by FitTanSipWcsTask) in order to converge. Please make makeCreateWcsWithSip fit for X and Y simultaneously. This would simplify its use and speed up fitting.

      In addition, please investigate whether outlier rejection can be added to makeCreateWcsWithSip. As of DM-3492 outlier rejection is implemented in FitTanSipWcsTask, but it would make makeCreateWcsWithSip easier to use and speed up fitting if makeCreateWcsWithSip did the outlier rejection itself. On the other hand, the current solution may be sufficient.

      Once the above is implemented, please simplify FitTanSipWcsTask by removing the unneeded extra iterations used to work around these problems.

      1. sip_tx.pdf
        140 kB
        Fred Moolekamp
      1. MACSJ2243_u_0_3,8.png
        581 kB

        Issue Links

          Activity

          Hide
          fred3m Fred Moolekamp added a comment - - edited

          The code looks good to me. There are two things that concern me slightly, which may be best covered in new tickets.

          The first is that the CRPIX values are set to the center of each CCD. Even if we don't attempt to fit the CRPIX values, I think it would be best to use the center of the focal plane, not the center of each CCD, as the origin of the polynomial expansion. I'm fairly certain that the fit will be much better, and there could potentially be CCD to CCD variances in the astrometric accuracy as the symmetry of the focal plane will affect the polynomial fit of a given CCD.

          The other issue is the question as to whether or not it is ok to keep the linear terms (A_10, A_01, B_10, B_01) in the FITS header. I attached a document to this ticket that I wrote describing how to transform from polynomial coefficients to the CD matrix and 2nd order (and higher) A,B coefficients, more in line with the SIP standard.

          Show
          fred3m Fred Moolekamp added a comment - - edited The code looks good to me. There are two things that concern me slightly, which may be best covered in new tickets. The first is that the CRPIX values are set to the center of each CCD. Even if we don't attempt to fit the CRPIX values, I think it would be best to use the center of the focal plane, not the center of each CCD, as the origin of the polynomial expansion. I'm fairly certain that the fit will be much better, and there could potentially be CCD to CCD variances in the astrometric accuracy as the symmetry of the focal plane will affect the polynomial fit of a given CCD. The other issue is the question as to whether or not it is ok to keep the linear terms (A_10, A_01, B_10, B_01) in the FITS header. I attached a document to this ticket that I wrote describing how to transform from polynomial coefficients to the CD matrix and 2nd order (and higher) A,B coefficients, more in line with the SIP standard.
          Hide
          jbosch Jim Bosch added a comment -

          I've created a new issue for reconsidering nulling the low-order SIP terms, as Fred Moolekamp has proposed.

          Show
          jbosch Jim Bosch added a comment - I've created a new issue for reconsidering nulling the low-order SIP terms, as Fred Moolekamp has proposed.
          Hide
          jbosch Jim Bosch added a comment -

          Merged to master following successful Jenkins runs (including py3). Big thanks to all reviewers and testers!

          Show
          jbosch Jim Bosch added a comment - Merged to master following successful Jenkins runs (including py3). Big thanks to all reviewers and testers!
          Hide
          swinbank John Swinbank added a comment -

          Jim Bosch: Could you add a brief note to the release notes (https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+F16+Release+Notes) describing what has been done here, please? That should certainly include a brief description of why this is better than the old implementation. It's not immediately obvious to me from scanning this issue whether this has caused any interface changes which will be noticeable to external users (ie, somebody who just wants to run a task to get their work done, rather than diving into the code); if so, please also mention them in the notes.

          Show
          swinbank John Swinbank added a comment - Jim Bosch : Could you add a brief note to the release notes ( https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+F16+Release+Notes ) describing what has been done here, please? That should certainly include a brief description of why this is better than the old implementation. It's not immediately obvious to me from scanning this issue whether this has caused any interface changes which will be noticeable to external users (ie, somebody who just wants to run a task to get their work done, rather than diving into the code); if so, please also mention them in the notes.
          Hide
          jbosch Jim Bosch added a comment -

          Release notes have been updated. Thanks for the reminder, and I'm sorry it was necessary.

          Show
          jbosch Jim Bosch added a comment - Release notes have been updated. Thanks for the reminder, and I'm sorry it was necessary.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              rowen Russell Owen
              Reviewers:
              Russell Owen
              Watchers:
              Colin Slater, David Shupe, Dominique Boutigny, Fred Moolekamp, Jim Bosch, John Swinbank, Nicolas Chotard, Paul Price, Pierre Astier, Robert Lupton, Russell Owen, Simon Krughoff, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile