Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35496

ra/decl columns in sourceTable still aren't updated in recalibration step

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S22B
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      WriteReCalibratedSourceTable didn't update the coord_ra/coord_dec columns. 

      import lsst.daf.butler as dafButler
      		 
      butler = dafButler.Butler('/repo/main', collections=['HSC/runs/RC2/w_2022_24/DM-35231'])
      		 
      ps = butler.get('preSourceTable', visit=30504, detector=54)
      		 
      s = butler.get('sourceTable', visit=30504, detector=54)
      		 
      np.sum(s.ra - ps.ra)

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          Jenkins: https://ci.lsst.codes/job/stack-os-matrix/36902/display/redirect

          To test I did:

          pipetask run -b /repo/main -i HSC/runs/RC2/w_2022_24/DM-35231 -o u/yusra/HSC/runs/RC2/w_2022_28_calibrate -d "instrument='HSC' AND detector=54 AND visit=30504" -p $DRP_PIPE_DIR/pipelines/HSC/DRP-RC2.yaml#writeRecalibratedSourceTable,transformSourceTable


          import numpy as np
          		 
          import lsst.daf.butler as dafButler
          		 
          butler = dafButler.Butler('/repo/main', collections=['u/yusra/HSC/runs/RC2/w_2022_28_calibrate'])
          		 
          ps = butler.get('preSourceTable', visit=30504, detector=54)
          		 
          s = butler.get('sourceTable', visit=30504, detector=54)
          		 
          np.sum(s.ra - ps.ra)

          Show
          yusra Yusra AlSayyad added a comment - Jenkins: https://ci.lsst.codes/job/stack-os-matrix/36902/display/redirect To test I did: pipetask run -b /repo/main -i HSC/runs/RC2/w_2022_24/DM-35231 -o u/yusra/HSC/runs/RC2/w_2022_28_calibrate -d "instrument='HSC' AND detector=54 AND visit=30504" -p $DRP_PIPE_DIR/pipelines/HSC/DRP-RC2.yaml#writeRecalibratedSourceTable,transformSourceTable import numpy as np import lsst.daf.butler as dafButler butler = dafButler.Butler('/repo/main', collections=['u/yusra/HSC/runs/RC2/w_2022_28_calibrate']) ps = butler.get('preSourceTable', visit=30504, detector=54) s = butler.get('sourceTable', visit=30504, detector=54) np.sum(s.ra - ps.ra)
          Hide
          Permalink
          yusra Yusra AlSayyad added a comment -

          Thank you for the review! I added an inline comment and rewrote the config parameter docstrings per how I think about them. Let me know if they make sense. I'm planning to merge EOB tomorrow.

          Show
          yusra Yusra AlSayyad added a comment - Thank you for the review! I added an inline comment and rewrote the config parameter docstrings per how I think about them. Let me know if they make sense. I'm planning to merge EOB tomorrow.

            People

            Assignee:
            yusra Yusra AlSayyad
            Reporter:
            yusra Yusra AlSayyad
            Reviewers:
            Clare Saunders
            Watchers:
            Clare Saunders, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.