Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35518

Fix ROT_PA=None for comCam data

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      We have started (properly) to write a ROT_PA header with an undefined value when the observation is not on sky. Currently the header translator for comCam does not expect that and stores a None in the value. That's not necessarily a problem except the butler ingest code assumes that the rotation angle is always defined.

      • Fix ingest so that None can be handled (not sure if it should go to NULL or 0.0)
      • Possibly fix obs_lsst to default to 0.0.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Turns out that the real bug was something completely different. A default value was supplied for the boresight rotation angle but because there was a bug in the code that was checking for whether this was a science observation or not the default never got applied.

            Embarrassingly I fixed this specifically for the LATISS translator 3 years ago in DM-21853.

            Show
            tjenness Tim Jenness added a comment - Turns out that the real bug was something completely different. A default value was supplied for the boresight rotation angle but because there was a bug in the code that was checking for whether this was a science observation or not the default never got applied. Embarrassingly I fixed this specifically for the LATISS translator 3 years ago in DM-21853 .
            Hide
            mkowalik Mikolaj Kowalik added a comment -

            Looks good to me.

            Following your suggestion from our Slack conversation I pushed one more commit changing the default value of boresight_rotation_angle from NaN to 0.0 and now I'm able to ingest recent raw images from Comcam to a Gen3 Bulter repo with no problem.

            Show
            mkowalik Mikolaj Kowalik added a comment - Looks good to me. Following your suggestion from our Slack conversation I pushed one more commit changing the default value of boresight_rotation_angle from NaN to 0.0 and now I'm able to ingest recent raw images from Comcam to a Gen3 Bulter repo with no problem.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Mikolaj Kowalik
              Watchers:
              Kian-Tat Lim, Mikolaj Kowalik, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.