Details
-
Type:
Story
-
Status: To Do
-
Resolution: Unresolved
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:
-
Story Points:1
-
Team:Alert Production
-
Urgent?:No
Description
Per this comment from Hisanori Furusawa, the MAGZERO FITS header column (the photometric zeropoint scaled by the exposure time) is no longer needed by HSC. We've already had one user confused by how it's different from what is printed by CalibrateTask/PhotoCalTask. We should remove MAGZERO, MAGZERO_RMS, MAGZERO_NOBJ, and COLORTERM[123] as we don't use them internally, MAGZERO doesn't match PhotoCalib because of the exposure time scaling, and COLORTERM[123] is always zero.
If we want a place to store metadata from PhotoCalTask (e.g. number of used sources), we should put that in the task metadata so that it's written in the same manner as the rest of our metadata.
I agree to remove confusing redundant MAGZERO (as it can be calculated by other keywords, too), but we (some) might keep RMS and NOBJ, which are still be useful for assess quality from the header only (We have to dig in log outputs to recover them) - just a comment. I agree to safely remove COLORTERMs. They were meant to put color term coefficients determined or used on processing but have not been implemented that way.