# Pass opticalModel to wfEsti in calcZernikesTask

XMLWordPrintable

#### Details

• Type: Improvement
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
3
• Team:
Telescope and Site

#### Description

Currently the gen3 middleware tasks  in ts_wep like estimateZernikesBase pass opticalModel and defocalDisInMm as to wfEsti as parts of the config  , but calcZernikesTask doesn't  . Add these options to calcZernikesTask so that it is possible to specify opticalModel when calculating Zernikes from already ingested donut stamps.

#### Activity

Hide
Krzysztof Suberlak added a comment -

It is already passed along in the https://github.com/lsst-ts/ts_wep/blob/96ffe9be7795e9dd6d3627880e17b49a9dbea414/python/lsst/ts/wep/task/CalcZernikesTask.py#L174 . This PR https://github.com/lsst-ts/ts_wep/pull/159 will include moving away from EstimateZernikes... family of classes, to CalcZernikes. I also tested the corner sensors and auxTel data - in both cases selecting different opticalModel affects the recovered Zernikes (using the test data from test_calcZernikesTaskLatiss.py and test_calcZernikesTaskCwfs.py ).

Show
Krzysztof Suberlak added a comment - It is already passed along in the https://github.com/lsst-ts/ts_wep/blob/96ffe9be7795e9dd6d3627880e17b49a9dbea414/python/lsst/ts/wep/task/CalcZernikesTask.py#L174 . This PR https://github.com/lsst-ts/ts_wep/pull/159 will include moving away from EstimateZernikes... family of classes, to CalcZernikes. I also tested the corner sensors and auxTel data - in both cases selecting different opticalModel affects the recovered Zernikes (using the test data from test_calcZernikesTaskLatiss.py and test_calcZernikesTaskCwfs.py ).
Hide
Krzysztof Suberlak added a comment -

The PR#160 to ts_wep addressed ensuring that ValueError is raised when an optical model that has not been implemented for auxTel, but has been implemented for other instruments such as LsstCam, ComCam (that is the case for "offAxis"). It has already been merged and released as ts_wep v3.1.5

Show
Krzysztof Suberlak added a comment - The PR#160 to ts_wep addressed ensuring that ValueError is raised when an optical model that has not been implemented for auxTel, but has been implemented for other instruments such as LsstCam, ComCam (that is the case for "offAxis"). It has already been merged and released as ts_wep v3.1.5
Hide
Krzysztof Suberlak added a comment -

As mentioned in comments, the initial scope of this ticket has been implemented before, and I added a ValueError to ensure that all instruments can provide meaningful results with whichever of the three optical models currently implemented ('onAxis', 'offAxis', 'paraxial').

Show
Krzysztof Suberlak added a comment - As mentioned in comments, the initial scope of this ticket has been implemented before, and I added a ValueError to ensure that all instruments can provide meaningful results with whichever of the three optical models currently implemented ('onAxis', 'offAxis', 'paraxial').
Hide
Bryce Kalmbach added a comment -

Reviewed and merged on Github

Show
Bryce Kalmbach added a comment - Reviewed and merged on Github

#### People

Assignee:
Krzysztof Suberlak
Reporter:
Krzysztof Suberlak
Reviewers:
Bryce Kalmbach
Watchers:
Bryce Kalmbach, Krzysztof Suberlak, Tiago Ribeiro